PonyMirrors/philomena
1
0
Fork 0
mirror of https://github.com/philomena-dev/philomena.git synced 2024-11-27 13:47:58 +01:00
Code Issues Projects Releases Packages Wiki Activity

fixes #74: only reencode the image when there is no choice to fix the orientation

Browse source
This commit is contained in:
byte[] 2020-04-29 23:29:05 -04:00
parent be520b1d7c
commit d82bb4f33f
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
lib/philomena/processors/jpeg.ex
View file

@ -26,7 +26,17 @@ defmodule Philomena.Processors.Jpeg do
defp strip(file) do
stripped = Briefly.create!(extname: ".jpg")
{_output, 0} = System.cmd("convert", [file, "-auto-orient", "-strip", stripped])
# ImageMagick always reencodes the image, resulting in quality loss, so
# be more clever
case System.cmd("identify", ["-format", "%[orientation]", file]) do
{"Undefined", 0} ->
# Strip EXIF without touching orientation
{_output, 0} = System.cmd("jpegtran", ["-copy", "none", "-outfile", stripped, file])
{_output, 0} ->
# Strip EXIF and reorient image
{_output, 0} = System.cmd("convert", [file, "-auto-orient", "-strip", stripped])
end
stripped
end