PonyMirrors/philomena
1
0
Fork 0
mirror of https://github.com/philomena-dev/philomena.git synced 2024-11-27 13:47:58 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #370 from philomena-dev/sources-fix

Browse source 
Fix single-source saving bug
This commit is contained in:
liamwhite 2024-11-15 08:42:19 -05:00 committed by GitHub
commit d218a2f45e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
lib/philomena_web/controllers/image/source_controller.ex
View file

@ -4,6 +4,7 @@ defmodule PhilomenaWeb.Image.SourceController do
alias Philomena.SourceChanges.SourceChange
alias Philomena.UserStatistics
alias Philomena.Images.Image
alias Philomena.Images.Source
alias Philomena.Images
alias Philomena.Repo
import Ecto.Query
@ -41,7 +42,9 @@ defmodule PhilomenaWeb.Image.SourceController do
PhilomenaWeb.Api.Json.ImageView.render("show.json", %{image: image, interactions: []})
)
changeset = Images.change_image(image)
changeset =
%{image | sources: sources_for_edit(image.sources)}
|> Images.change_image()
source_change_count =
SourceChange
@ -74,4 +77,9 @@ defmodule PhilomenaWeb.Image.SourceController do
)
end
end
# TODO: this is duplicated in ImageController
defp sources_for_edit(), do: [%Source{}]
defp sources_for_edit([]), do: sources_for_edit()
defp sources_for_edit(sources), do: sources
end

1
lib/philomena_web/controllers/image_controller.ex
View file

@ -219,6 +219,7 @@ defmodule PhilomenaWeb.ImageController do
end
end
# TODO: this is duplicated in Image.SourceController
defp sources_for_edit(), do: [%Source{}]
defp sources_for_edit([]), do: sources_for_edit()
defp sources_for_edit(sources), do: sources