PonyMirrors/philomena
1
0
Fork 0
mirror of https://github.com/philomena-dev/philomena.git synced 2025-01-20 06:37:59 +01:00
Code Issues Projects Releases Packages Wiki Activity

reintroduce transaction and add impossible condition to first element of reduce step

Browse source
This commit is contained in:
byte[] 2020-07-13 23:44:45 -04:00
parent e3c6610fcd
commit b97073ee18
1 changed files with 41 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

75
lib/philomena/tag_changes.ex
View file

@ -37,59 +37,66 @@ defmodule Philomena.TagChanges do
to_remove = to_remove =
added added
|> Enum.map(&{&1.image_id, &1.tag_id}) |> Enum.map(&{&1.image_id, &1.tag_id})
|> Enum.reduce(Tagging, fn {image_id, tag_id}, q -> |> Enum.reduce(where(Tagging, fragment("'t' = 'f'")), fn {image_id, tag_id}, q ->
or_where(q, image_id: ^image_id, tag_id: ^tag_id) or_where(q, image_id: ^image_id, tag_id: ^tag_id)
end) end)
|> select([t], [t.image_id, t.tag_id]) |> select([t], [t.image_id, t.tag_id])
to_add = Enum.map(removed, &%{image_id: &1.image_id, tag_id: &1.tag_id}) to_add = Enum.map(removed, &%{image_id: &1.image_id, tag_id: &1.tag_id})
{_count, inserted} = Repo.transaction(fn ->
Repo.insert_all(Tagging, to_add, on_conflict: :nothing, returning: [:image_id, :tag_id]) {_count, inserted} =
Repo.insert_all(Tagging, to_add, on_conflict: :nothing, returning: [:image_id, :tag_id])
{_count, deleted} = Repo.delete_all(to_remove) {_count, deleted} = Repo.delete_all(to_remove)
inserted = Enum.map(inserted, &[&1.image_id, &1.tag_id]) inserted = Enum.map(inserted, &[&1.image_id, &1.tag_id])
added_changes = added_changes =
Enum.map(inserted, fn [image_id, tag_id] -> Enum.map(inserted, fn [image_id, tag_id] ->
Map.merge(tag_change_attributes, %{image_id: image_id, tag_id: tag_id, added: true}) Map.merge(tag_change_attributes, %{image_id: image_id, tag_id: tag_id, added: true})
end) end)
removed_changes = removed_changes =
Enum.map(deleted, fn [image_id, tag_id] -> Enum.map(deleted, fn [image_id, tag_id] ->
Map.merge(tag_change_attributes, %{image_id: image_id, tag_id: tag_id, added: false}) Map.merge(tag_change_attributes, %{image_id: image_id, tag_id: tag_id, added: false})
end) end)
Repo.insert_all(TagChange, added_changes ++ removed_changes) Repo.insert_all(TagChange, added_changes ++ removed_changes)
# In order to merge into the existing tables here in one go, insert_all # In order to merge into the existing tables here in one go, insert_all
# is used with a query that is guaranteed to conflict on every row by # is used with a query that is guaranteed to conflict on every row by
# using the primary key. # using the primary key.
added_upserts = added_upserts =
inserted inserted
|> Enum.group_by(fn [_image_id, tag_id] -> tag_id end) |> Enum.group_by(fn [_image_id, tag_id] -> tag_id end)
|> Enum.map(fn {tag_id, instances} -> |> Enum.map(fn {tag_id, instances} ->
Map.merge(tag_attributes, %{id: tag_id, images_count: length(instances)}) Map.merge(tag_attributes, %{id: tag_id, images_count: length(instances)})
end) end)
removed_upserts = removed_upserts =
deleted deleted
|> Enum.group_by(fn [_image_id, tag_id] -> tag_id end) |> Enum.group_by(fn [_image_id, tag_id] -> tag_id end)
|> Enum.map(fn {tag_id, instances} -> |> Enum.map(fn {tag_id, instances} ->
Map.merge(tag_attributes, %{id: tag_id, images_count: -length(instances)}) Map.merge(tag_attributes, %{id: tag_id, images_count: -length(instances)})
end) end)
update_query = update(Tag, inc: [images_count: fragment("EXCLUDED.images_count")]) update_query = update(Tag, inc: [images_count: fragment("EXCLUDED.images_count")])
upserts = added_upserts ++ removed_upserts upserts = added_upserts ++ removed_upserts
Repo.insert_all(Tag, upserts, on_conflict: update_query, conflict_target: [:id]) Repo.insert_all(Tag, upserts, on_conflict: update_query, conflict_target: [:id])
end)
|> case do
{:ok, _result} ->
Images.reindex_images(image_ids)
Images.reindex_images(image_ids) {:ok, tag_changes}
{:ok, tag_changes} error ->
error
end
end end
@doc """ @doc """