Hide Queue staff link if user can't approve images (#200)

This commit is contained in:
Eliot Partridge 2023-12-03 20:56:32 -05:00 committed by GitHub
parent cf013cd0c3
commit 217621a9e1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 6 deletions

View file

@ -210,11 +210,15 @@ defmodule Philomena.Images do
defp maybe_suggest_user_verification(_user), do: false defp maybe_suggest_user_verification(_user), do: false
def count_pending_approvals() do def count_pending_approvals(user) do
if Canada.Can.can?(user, :approve, %Image{}) do
Image Image
|> where(hidden_from_users: false) |> where(hidden_from_users: false)
|> where(approved: false) |> where(approved: false)
|> Repo.aggregate(:count) |> Repo.aggregate(:count)
else
nil
end
end end
def feature_image(featurer, %Image{} = image) do def feature_image(featurer, %Image{} = image) do

View file

@ -32,7 +32,7 @@ defmodule PhilomenaWeb.AdminCountersPlug do
defp maybe_assign_admin_metrics(conn, _user, false), do: conn defp maybe_assign_admin_metrics(conn, _user, false), do: conn
defp maybe_assign_admin_metrics(conn, user, true) do defp maybe_assign_admin_metrics(conn, user, true) do
pending_approvals = Images.count_pending_approvals() pending_approvals = Images.count_pending_approvals(user)
duplicate_reports = DuplicateReports.count_duplicate_reports(user) duplicate_reports = DuplicateReports.count_duplicate_reports(user)
reports = Reports.count_reports(user) reports = Reports.count_reports(user)
artist_links = ArtistLinks.count_artist_links(user) artist_links = ArtistLinks.count_artist_links(user)