PonyMirrors/Unicopia
1
0
Fork 0
mirror of https://github.com/Sollace/Unicopia.git synced 2025-01-31 19:16:44 +01:00
Code Issues Projects Releases Packages Wiki Activity

Clear some todos

Browse source
This commit is contained in:
Sollace 2022-12-26 21:45:38 +01:00
parent 25044b6f69
commit ef318822c1
4 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/main/java/com/minelittlepony/unicopia/ability/magic/spell/trait/TraitGroup.java
View file

@ -12,7 +12,6 @@ public enum TraitGroup {
this.corruption = corruption;
}
// TODO: implement corruption mechanics
public float getCorruption() {
return corruption;
}

4
src/main/java/com/minelittlepony/unicopia/block/state/StatePredicate.java
View file

@ -12,6 +12,7 @@ import com.google.common.base.Predicates;
import com.google.gson.JsonElement;
import com.google.gson.JsonObject;
import net.fabricmc.fabric.api.tag.convention.v1.ConventionalBlockTags;
import net.minecraft.block.*;
import net.minecraft.state.property.Property;
import net.minecraft.util.Identifier;
@ -118,8 +119,7 @@ public abstract class StatePredicate implements Predicate<BlockState> {
}
static boolean isOre(BlockState s) {
// TODO: Use ConventionalBlockTags.ORES
return s.getBlock() instanceof ExperienceDroppingBlock && !(s.getBlock() instanceof SculkBlock);
return s.isIn(ConventionalBlockTags.ORES);
}
static boolean isWater(BlockState s) {

1
src/main/java/com/minelittlepony/unicopia/client/particle/DiskParticle.java
View file

@ -16,7 +16,6 @@ public class DiskParticle extends SphereParticle {
public DiskParticle(SphereParticleEffect effect, ClientWorld w, double x, double y, double z, double rX, double rY, double rZ) {
super(effect, w, x, y, z, 0, 0, 0);
// TODO: was hamiltonianProduct (check this!!!)
rotation.mul(RotationAxis.POSITIVE_Y.rotationDegrees((float)effect.getOffset().y));
rotation.mul(RotationAxis.POSITIVE_X.rotationDegrees(90 - (float)effect.getOffset().x));

2
src/main/java/com/minelittlepony/unicopia/client/particle/RunesParticle.java
View file

@ -90,11 +90,9 @@ public class RunesParticle extends OrientedBillboardParticle implements Attachme
}
if (key == ATTR_PITCH) {
rotation = new Quaternionf(0, 0, 0, 1);
// TODO: Was hamiltonianProduct (CHECK!!!)
rotation.mul(RotationAxis.POSITIVE_Y.rotationDegrees(value.floatValue()));
}
if (key == ATTR_YAW) {
// TODO: Was hamiltonianProduct (CHECK!!!)
rotation.mul(RotationAxis.POSITIVE_X.rotationDegrees(180 - value.floatValue()));
}
}