PonyMirrors/Pony.fm
1
0
Fork 0
mirror of https://github.com/Poniverse/Pony.fm.git synced 2024-11-22 13:07:59 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fixed race condition in genre deletion

Browse source
This commit is contained in:
Josef Citrine 2017-05-17 02:38:22 +01:00
parent 9e63702387
commit d7fc5f02cf
1 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
app/Jobs/DeleteGenre.php
View file

@ -63,14 +63,17 @@ class DeleteGenre extends Job implements ShouldQueue
// This is done instead of a single UPDATE query in order to // This is done instead of a single UPDATE query in order to
// generate revision logs for the change. // generate revision logs for the change.
$this->genreToDelete->tracks()->each(function ($track) { $tracks = Track::whereGenreId($this->genreToDelete->id)->get();
/** @var Track $track */
$track->genre_id = $this->destinationGenre->id;
$track->save();
$track->updateTags();
});
$this->genreToDelete->delete(); $this->genreToDelete->delete();
$chunks = $tracks->chunk(200);
foreach ($chunks as $chunk) {
foreach ($chunk as $track) {
$track->genre_id = $this->destinationGenre->id;
$track->save();
$track->updateTags();
}
}
} }
} }