PonyMirrors/Pony.fm
1
0
Fork 0
mirror of https://github.com/Poniverse/Pony.fm.git synced 2024-11-27 15:27:58 +01:00
Code Issues Projects Releases Packages Wiki Activity

Null handling of soft deleted tracks for favourites page

Browse source 
Null handling of soft deleted tracks for favourites page
This commit is contained in:
Alex Ramirez 2023-11-12 23:05:38 -08:00 committed by GitHub
commit 4bec8e2587
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/Models/Favourite.php
View file

@ -91,8 +91,11 @@ class Favourite extends Model
} else { } else {
if ($this->playlist_id) { if ($this->playlist_id) {
return $this->playlist; return $this->playlist;
} // no resource - this should never happen under real circumstances }
else { else {
// No resource
// In this case, either the resource was
// soft-deleted or something else occurred.
return null; return null;
} }
} }
@ -101,6 +104,8 @@ class Favourite extends Model
public function getTypeAttribute() public function getTypeAttribute()
{ {
return get_class($this->resource); // As of PHP 7.2, get_class is picky about null args
$resource = $this->resource;
return $resource ? get_class($resource) : null;
} }
} }