T126: Fixed standard profiles appearing as archived profiles.

Summary:
The `is_archived` attribute on the `User` model did not explicitly come
back as any particular type. The resulting JSON had the string `"0"` for what's
meant to be a falsey value, but it evaluated to truthy in JS.

`is_archived` now has a getter which explicitly casts it to `boolean` before being
returned anywhere.

Test Plan: Manually tested in dev.

Reviewers: Feld0

Reviewed By: Feld0

Subscribers: #pony.fm

Projects: #pony.fm

Maniphest Tasks: T126

Differential Revision: https://phabricator.poniverse.net/D6

app/models/Entities/User.php

@@ -37,6 +37,10 @@
 			return $this->hasMany('Entities\Comment', 'profile_id')->orderBy('created_at', 'desc');
 		}
 
+		public function getIsArchivedAttribute() {
+			return (bool) $this->attributes['is_archived'];
+		}
+
 		public function getUrlAttribute() {
 			return URL::to('/' . $this->slug);
 		}

gulpfile.js

@@ -164,7 +164,7 @@ gulp.task('build', [
     'scripts-app',
     'styles-app',
     'scripts-embed',
-    'styles-embed',
+    'styles-embed'
 ]);
 
 gulp.task("watch", function() {