General code cleanup.

Generic types
Unnecessary casts
Unused imports

src/main/java/com/minelittlepony/client/PonyRenderManager.java

@@ -17,7 +17,6 @@ import net.fabricmc.fabric.api.client.render.EntityRendererRegistry;
 import net.minecraft.client.MinecraftClient;
 import net.minecraft.client.render.entity.EntityRenderDispatcher;
 import net.minecraft.client.render.entity.EntityRenderer;
-import net.minecraft.client.render.entity.LivingEntityRenderer;
 import net.minecraft.client.render.entity.PlayerEntityRenderer;
 import net.minecraft.client.render.entity.model.EntityModel;
 import net.minecraft.entity.Entity;
@@ -100,15 +99,15 @@ public class PonyRenderManager {
 
     @SuppressWarnings("unchecked")
     @Nullable
-    public <T extends LivingEntity, M extends EntityModel<T> & IPonyModel<T>, R extends LivingEntityRenderer<T, M> & IPonyRender<T, M>> R getPonyRenderer(@Nullable Entity entity) {
+    public <T extends LivingEntity, M extends EntityModel<T> & IPonyModel<T>> IPonyRender<T, M> getPonyRenderer(@Nullable T entity) {
-        if (entity == null || !(entity instanceof LivingEntity)) {
+        if (entity == null) {
             return null;
         }
 
-        EntityRenderer<Entity> renderer = MinecraftClient.getInstance().getEntityRenderManager().getRenderer(entity);
+        EntityRenderer<T> renderer = MinecraftClient.getInstance().getEntityRenderManager().getRenderer(entity);
 
         if (renderer instanceof IPonyRender) {
-            return (R)(Object)renderer;
+            return (IPonyRender<T, M>) renderer;
         }
 
         return null;

src/main/java/com/minelittlepony/client/gui/GuiPonySettings.java

@@ -70,7 +70,7 @@ public class GuiPonySettings extends GameGui {
 
         int row = 0;
 
-        ((List<Element>)children()).add(content);
+        children().add(content);
 
         addButton(new Label(width / 2, 5).setCentered()).getStyle().setText(getTitle().getString());
         addButton(new Button(width / 2 - 100, height - 25))

src/main/java/com/minelittlepony/client/pony/Pony.java

@@ -206,16 +206,22 @@ public class Pony implements IPony {
 
     @Override
     public boolean isRidingInteractive(LivingEntity entity) {
-        return PonyRenderManager.getInstance().getPonyRenderer(entity.getVehicle()) != null;
+        if (entity.hasVehicle() && entity.getVehicle() instanceof LivingEntity) {
+            return PonyRenderManager.getInstance().getPonyRenderer((LivingEntity) entity.getVehicle()) != null;
+        }
+        return false;
     }
 
     @Override
     public IPony getMountedPony(LivingEntity entity) {
-        Entity mount = entity.getVehicle();
+        if (entity.hasVehicle() && entity.getVehicle() instanceof LivingEntity) {
+            LivingEntity mount = (LivingEntity) entity.getVehicle();
 
             IPonyRender<LivingEntity, ?> render = PonyRenderManager.getInstance().getPonyRenderer(mount);
 
-        return render == null ? null : render.getEntityPony((LivingEntity)mount);
+            return render == null ? null : render.getEntityPony(mount);
+        }
+        return null;
     }
 
     @Override

src/main/java/com/minelittlepony/client/render/RenderPony.java

@@ -68,21 +68,19 @@ public class RenderPony<T extends LivingEntity, M extends EntityModel<T> & IPony
         return rotationYaw;
     }
 
-    protected void translateRider(LivingEntity entity, float ticks) {
+    protected void translateRider(T entity, float ticks) {
-        if (entity.hasVehicle()) {
+        if (entity.hasVehicle() && entity.getVehicle() instanceof LivingEntity) {
-            Entity ridingEntity = entity.getVehicle();
 
-            if (ridingEntity instanceof LivingEntity) {
+            LivingEntity ridingEntity = (LivingEntity) entity.getVehicle();
-                IPonyRender<LivingEntity, ?> renderer = PonyRenderManager.getInstance().getPonyRenderer((LivingEntity)ridingEntity);
+            IPonyRender<LivingEntity, ?> renderer = PonyRenderManager.getInstance().getPonyRenderer(ridingEntity);
 
             if (renderer != null) {
                 // negate vanilla translations so the rider begins at the ridees feet.
                 GlStateManager.translatef(0, -ridingEntity.getHeight(), 0);
 
-                    IPony riderPony = renderer.getEntityPony((LivingEntity)ridingEntity);
+                IPony riderPony = renderer.getEntityPony(ridingEntity);
 
-                    renderer.translateRider((LivingEntity)ridingEntity, riderPony, entity, pony, ticks);
+                renderer.translateRider(ridingEntity, riderPony, entity, pony, ticks);
-                }
             }
         }
     }

src/main/java/com/minelittlepony/client/transform/PostureFlight.java

@@ -23,6 +23,6 @@ public class PostureFlight extends MotionCompositor implements PonyPosture<Playe
 
         roll = model.getMetadata().getInterpolator(player.getUuid()).interpolate("pegasusRoll", roll, 10);
 
-        GlStateManager.rotatef((float)roll, 0, 0, 1);
+        GlStateManager.rotatef(roll, 0, 0, 1);
     }
 }

src/main/java/com/minelittlepony/pony/meta/Wearable.java

@@ -30,6 +30,6 @@ public enum Wearable implements ITriggerPixelMapped<Wearable> {
         for (int i = 0; i < values.length; i++) {
             if (flags[i]) wears.add(values[i]);
         }
-        return wears.stream().toArray(Wearable[]::new);
+        return wears.toArray(new Wearable[0]);
     }
 }

src/main/java/com/minelittlepony/settings/PonyLevel.java

@@ -10,6 +10,6 @@ public enum PonyLevel {
         if (index < 0) {
             index = 0;
         }
-        return values[(int)Math.round(index) % values.length];
+        return values[Math.round(index) % values.length];
     }
 }