Migrate to jebrains annotations

build.gradle

@@ -4,8 +4,11 @@ plugins {
     id 'maven-publish'
 }
 
-targetCompatibility = JavaVersion.VERSION_16
+java {
-sourceCompatibility = JavaVersion.VERSION_16
+    toolchain {
+        languageVersion = JavaLanguageVersion.of(16)
+    }
+}
 
 def createVersion() {
     def parts = []
@@ -59,8 +62,6 @@ dependencies {
     mappings "net.fabricmc:yarn:${project.yarn_mappings}:v2"
     modApi "net.fabricmc:fabric-loader:${project.loader_version}"
 
-    compileOnly "com.google.code.findbugs:jsr305:3.0.2"
-
     modApi fabricApi.module("fabric-api-base", project.fabric_version)
     modApi fabricApi.module("fabric-lifecycle-events-v1", project.fabric_version)
     modApi fabricApi.module("fabric-resource-loader-v0", project.fabric_version)

src/main/java/com/minelittlepony/api/model/armour/IArmourTextureResolver.java

@@ -5,7 +5,7 @@ import net.minecraft.entity.EquipmentSlot;
 import net.minecraft.item.ItemStack;
 import net.minecraft.util.Identifier;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 public interface IArmourTextureResolver {
 

src/main/java/com/minelittlepony/api/model/armour/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.api.model.armour;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/api/model/fabric/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.api.model.fabric;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/api/model/gear/IGear.java

@@ -11,7 +11,7 @@ import com.minelittlepony.api.model.IModel;
 import com.minelittlepony.api.pony.meta.Wearable;
 import com.minelittlepony.client.render.entity.feature.GearFeature;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.UUID;
 import java.util.function.Supplier;

src/main/java/com/minelittlepony/api/model/gear/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.api.model.gear;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/api/model/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.api.model;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/api/pony/meta/Race.java

@@ -2,7 +2,7 @@ package com.minelittlepony.api.pony.meta;
 
 import com.minelittlepony.api.pony.TriggerPixelType;
 
-import javax.annotation.Nonnull;
+import org.jetbrains.annotations.NotNull;
 
 public enum Race implements TriggerPixelType<Race> {
 
@@ -73,7 +73,7 @@ public enum Race implements TriggerPixelType<Race> {
      * Gets the original race that this one is an alias for, if one exists.
      * Otherwise returns this race.
      */
-    @Nonnull
+    @NotNull
     public Race getAlias() {
         return original;
     }

src/main/java/com/minelittlepony/api/pony/meta/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.api.pony.meta;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/api/pony/network/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.api.pony.network;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/api/pony/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.api.pony;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/GuiPonySettings.java

@@ -18,7 +18,7 @@ import com.minelittlepony.common.client.gui.element.Slider;
 import com.minelittlepony.common.client.gui.element.Toggle;
 import com.minelittlepony.common.util.settings.Setting;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 /**
  * In-Game options menu.

src/main/java/com/minelittlepony/client/SkinsProxy.java

@@ -13,7 +13,7 @@ import net.minecraft.client.network.AbstractClientPlayerEntity;
 import net.minecraft.client.texture.PlayerSkinProvider;
 import net.minecraft.util.Identifier;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 public class SkinsProxy {
 

src/main/java/com/minelittlepony/client/hdskins/MineLPHDSkins.java

@@ -16,7 +16,7 @@ import com.minelittlepony.hdskins.profile.SkinType;
 
 import com.mojang.authlib.GameProfile;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import net.fabricmc.api.ClientModInitializer;
 import net.minecraft.client.MinecraftClient;

src/main/java/com/minelittlepony/client/hdskins/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.hdskins;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/mixin/MixinFirstPersonRenderer.java

@@ -6,7 +6,7 @@ import org.spongepowered.asm.mixin.injection.Redirect;
 
 import com.minelittlepony.client.render.PonyRenderDispatcher;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import net.minecraft.client.render.item.HeldItemRenderer;
 import net.minecraft.client.render.VertexConsumerProvider;

src/main/java/com/minelittlepony/client/mixin/MixinSkullBlockEntityRenderer.java

@@ -19,7 +19,7 @@ import org.spongepowered.asm.mixin.injection.callback.CallbackInfoReturnable;
 import com.minelittlepony.client.render.blockentity.skull.PonySkullRenderer;
 import com.mojang.authlib.GameProfile;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 @Mixin(SkullBlockEntityRenderer.class)
 abstract class MixinSkullBlockEntityRenderer implements BlockEntityRenderer<SkullBlockEntity> {

src/main/java/com/minelittlepony/client/mixin/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.mixin;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/model/ModelType.java

@@ -43,7 +43,7 @@ import com.minelittlepony.mson.api.ModelKey;
 import com.minelittlepony.mson.api.Mson;
 import com.minelittlepony.mson.api.MsonModel;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.HashMap;
 import java.util.Map;

src/main/java/com/minelittlepony/client/model/armour/DefaultArmourTextureResolver.java

@@ -14,7 +14,7 @@ import com.minelittlepony.api.model.armour.ArmourVariant;
 import com.minelittlepony.api.model.armour.IArmourTextureResolver;
 import com.minelittlepony.util.ResourceUtil;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import java.nio.file.Path;
 import java.nio.file.Paths;

src/main/java/com/minelittlepony/client/model/armour/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.model.armour;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/model/entity/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.model.entity;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/model/entity/race/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.model.entity.race;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/model/gear/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.model.gear;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/model/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.model;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/model/part/UnicornHorn.java

@@ -13,7 +13,7 @@ import com.minelittlepony.common.util.Color;
 import com.minelittlepony.mson.api.ModelContext;
 import com.minelittlepony.mson.api.MsonModel;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import java.util.UUID;
 

src/main/java/com/minelittlepony/client/model/part/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.model.part;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/pony/NativePonyData.java

@@ -21,12 +21,12 @@ import java.util.Map;
 import java.util.TreeMap;
 import java.util.UUID;
 
-import javax.annotation.concurrent.Immutable;
+import org.jetbrains.annotations.Unmodifiable;
 
 /**
  * Implementation for IPonyData.
  */
-@Immutable
+@Unmodifiable
 class NativePonyData implements IPonyData {
     private final TriggerPixelValue<Race> race;
     private final TriggerPixelValue<TailLength> tailSize;

src/main/java/com/minelittlepony/client/pony/Pony.java

@@ -29,9 +29,9 @@ import net.minecraft.util.math.BlockPos;
 import net.minecraft.util.math.MathHelper;
 import net.minecraft.util.math.Vec3d;
 
-import javax.annotation.concurrent.Immutable;
+import org.jetbrains.annotations.Unmodifiable;
 
-@Immutable
+@Unmodifiable
 public class Pony implements IPony {
 
     private final Identifier texture;

src/main/java/com/minelittlepony/client/pony/PonyData.java

@@ -22,13 +22,13 @@ import java.util.Map;
 import java.util.TreeMap;
 import java.util.UUID;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
-import javax.annotation.concurrent.Immutable;
+import org.jetbrains.annotations.Unmodifiable;
 
 /**
  * Implementation for IPonyData.
  */
-@Immutable
+@Unmodifiable
 public class PonyData implements IPonyData {
 
     private static final PonyDataSerialiser SERIALISER = new PonyDataSerialiser();

src/main/java/com/minelittlepony/client/pony/PonyManager.java

@@ -8,7 +8,7 @@ import com.minelittlepony.api.pony.IPonyManager;
 import com.minelittlepony.client.MineLittlePony;
 import com.minelittlepony.settings.PonyConfig;
 import com.minelittlepony.settings.PonyLevel;
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import net.fabricmc.fabric.api.resource.IdentifiableResourceReloadListener;
 import net.minecraft.client.network.AbstractClientPlayerEntity;

src/main/java/com/minelittlepony/client/pony/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.pony;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/render/EquineRenderManager.java

@@ -12,7 +12,7 @@ import com.mojang.blaze3d.platform.GlStateManager.DstFactor;
 import com.mojang.blaze3d.platform.GlStateManager.SrcFactor;
 import com.mojang.blaze3d.systems.RenderSystem;
 
-import javax.annotation.Nonnull;
+import org.jetbrains.annotations.NotNull;
 
 import net.minecraft.client.render.Frustum;
 import net.minecraft.client.render.entity.model.EntityModel;
@@ -107,7 +107,7 @@ public class EquineRenderManager<T extends LivingEntity, M extends EntityModel<T
         ((PonyPosture<T>) getPosture(player)).apply(player, getModel(), stack, yaw, ticks, -1);
     }
 
-    @Nonnull
+    @NotNull
     private PonyPosture<?> getPosture(T entity) {
         if (entity.isFallFlying()) {
             return PonyPosture.ELYTRA;

src/main/java/com/minelittlepony/client/render/LevitatingItemRenderer.java

@@ -4,7 +4,7 @@ import com.minelittlepony.api.pony.IPony;
 import com.minelittlepony.client.MineLittlePony;
 import com.minelittlepony.common.util.Color;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import net.minecraft.client.MinecraftClient;
 import net.minecraft.client.render.OverlayTexture;

src/main/java/com/minelittlepony/client/render/PonyRenderDispatcher.java

@@ -7,7 +7,7 @@ import com.google.common.collect.Maps;
 import com.minelittlepony.client.model.IPonyModel;
 import com.minelittlepony.client.model.entity.race.PlayerModels;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 import com.minelittlepony.common.mixin.MixinEntityRenderDispatcher;
 import com.minelittlepony.mson.api.Mson;

src/main/java/com/minelittlepony/client/render/blockentity/skull/MobSkull.java

@@ -5,7 +5,7 @@ import com.minelittlepony.settings.PonyConfig;
 import com.mojang.authlib.GameProfile;
 import net.minecraft.util.Identifier;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 public class MobSkull extends AbstractPonySkull {
 

src/main/java/com/minelittlepony/client/render/blockentity/skull/PonySkull.java

@@ -13,7 +13,7 @@ import net.minecraft.client.util.math.MatrixStack;
 import net.minecraft.entity.player.PlayerEntity;
 import net.minecraft.util.Identifier;
 
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 public class PonySkull extends AbstractPonySkull {
 

src/main/java/com/minelittlepony/client/render/blockentity/skull/PonySkullRenderer.java

@@ -21,7 +21,7 @@ import net.minecraft.util.Util;
 import net.minecraft.util.math.Direction;
 
 import java.util.Map;
-import javax.annotation.Nullable;
+import org.jetbrains.annotations.Nullable;
 
 /**
  * PonySkullRenderer! It renders ponies as skulls, or something...

src/main/java/com/minelittlepony/client/render/blockentity/skull/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.render.blockentity.skull;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/render/entity/PonyRenderer.java

@@ -30,7 +30,7 @@ import net.minecraft.text.Text;
 import net.minecraft.util.Identifier;
 
 import java.util.List;
-import javax.annotation.Nonnull;
+import org.jetbrains.annotations.NotNull;
 
 public abstract class PonyRenderer<T extends MobEntity, M extends EntityModel<T> & IPonyModel<T>> extends MobEntityRenderer<T, M> implements IPonyRenderContext<T, M> {
 
@@ -113,7 +113,7 @@ public abstract class PonyRenderer<T extends MobEntity, M extends EntityModel<T>
 
     @Deprecated
     @Override
-    @Nonnull
+    @NotNull
     public final Identifier getTexture(T entity) {
         return findTexture(entity);
     }

src/main/java/com/minelittlepony/client/render/entity/SeaponyRenderer.java

@@ -1,6 +1,6 @@
 package com.minelittlepony.client.render.entity;
 
-import javax.annotation.Nonnull;
+import org.jetbrains.annotations.NotNull;
 
 import com.minelittlepony.client.mixin.IResizeable;
 import com.minelittlepony.client.model.ModelType;
@@ -43,7 +43,7 @@ public class SeaponyRenderer extends GuardianEntityRenderer {
     }
 
     @Override
-    @Nonnull
+    @NotNull
     public final Identifier getTexture(GuardianEntity entity) {
         return ponyRenderer.getTextureFor(entity);
     }

src/main/java/com/minelittlepony/client/render/entity/feature/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.render.entity.feature;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/render/entity/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.render.entity;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/render/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.render;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/settings/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.settings;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/client/transform/package-info.java

@@ -1,5 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.transform;
-
-import javax.annotation.ParametersAreNonnullByDefault;
-

src/main/java/com/minelittlepony/client/util/render/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.client.util.render;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/settings/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.settings;
-
-import javax.annotation.ParametersAreNonnullByDefault;

src/main/java/com/minelittlepony/util/package-info.java

@@ -1,4 +0,0 @@
-@ParametersAreNonnullByDefault
-package com.minelittlepony.util;
-
-import javax.annotation.ParametersAreNonnullByDefault;