We really don't need any of this

This commit is contained in:
Sollace 2018-07-31 09:59:27 +02:00
parent f32611a1eb
commit 2d0a71edb8
5 changed files with 11 additions and 20 deletions

View file

@ -206,10 +206,7 @@ public final class HDSkinManager implements IResourceManagerReloadListener {
Map<Type, MinecraftProfileTexture> textures = Maps.newEnumMap(Type.class); Map<Type, MinecraftProfileTexture> textures = Maps.newEnumMap(Type.class);
for (SkinServer server : skinServers) { for (SkinServer server : skinServers) {
MinecraftTexturesPayload payload = server.getProfileData(profile); server.getProfileTextures(profile).forEach(textures::putIfAbsent);
if (payload != null) {
payload.getTextures().forEach(textures::putIfAbsent);
}
} }
return textures; return textures;

View file

@ -38,7 +38,7 @@ public class PreviewTextureManager {
@Nullable @Nullable
private PreviewTexture loadPreviewTexture(ResourceLocation location, Type type, ResourceLocation def, @Nullable SkinAvailableCallback callback) { private PreviewTexture loadPreviewTexture(ResourceLocation location, Type type, ResourceLocation def, @Nullable SkinAvailableCallback callback) {
if (textures == null) { if (textures == null) {
textures = HDSkinManager.INSTANCE.getGatewayServer().getPreviewTextures(profile); textures = HDSkinManager.INSTANCE.getGatewayServer().getProfileTextures(profile);
} }
if (!textures.containsKey(type)) { if (!textures.containsKey(type)) {

View file

@ -4,7 +4,6 @@ import java.io.IOException;
import java.net.URI; import java.net.URI;
import java.util.Collections; import java.util.Collections;
import java.util.Map; import java.util.Map;
import java.util.Optional;
import java.util.concurrent.CompletableFuture; import java.util.concurrent.CompletableFuture;
import javax.annotation.Nullable; import javax.annotation.Nullable;
@ -32,15 +31,14 @@ public abstract class AbstractSkinServer implements SkinServer {
} }
@Override @Override
public final Optional<MinecraftTexturesPayload> loadProfileData(GameProfile profile) { public Map<Type, MinecraftProfileTexture> getProfileTextures(GameProfile profile) {
return Optional.ofNullable(getProfileData(profile)); MinecraftTexturesPayload payload = getProfileData(profile);
if (payload != null && payload.getTextures() != null) {
return payload.getTextures();
} }
@Override return Collections.emptyMap();
public Map<Type, MinecraftProfileTexture> getPreviewTextures(GameProfile profile) {
return loadProfileData(profile)
.map(MinecraftTexturesPayload::getTextures)
.orElse(Collections.emptyMap());
} }
@Override @Override

View file

@ -39,7 +39,7 @@ public class LegacySkinServer extends AbstractSkinServer {
} }
@Override @Override
public Map<Type, MinecraftProfileTexture> getPreviewTextures(GameProfile profile) { public Map<Type, MinecraftProfileTexture> getProfileTextures(GameProfile profile) {
Map<Type, MinecraftProfileTexture> map = new EnumMap<>(Type.class); Map<Type, MinecraftProfileTexture> map = new EnumMap<>(Type.class);
for (Type type : Type.values()) { for (Type type : Type.values()) {

View file

@ -18,7 +18,6 @@ import net.minecraft.util.Session;
import java.net.URI; import java.net.URI;
import java.util.List; import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Optional;
import java.util.UUID; import java.util.UUID;
import java.util.concurrent.CompletableFuture; import java.util.concurrent.CompletableFuture;
@ -34,12 +33,9 @@ public interface SkinServer extends Exposable {
"http://skins.voxelmodpack.com", "http://skins.voxelmodpack.com",
"http://skinmanager.voxelmodpack.com")); "http://skinmanager.voxelmodpack.com"));
@Deprecated
Optional<MinecraftTexturesPayload> loadProfileData(GameProfile profile);
MinecraftTexturesPayload getProfileData(GameProfile profile); MinecraftTexturesPayload getProfileData(GameProfile profile);
Map<MinecraftProfileTexture.Type, MinecraftProfileTexture> getPreviewTextures(GameProfile profile); Map<MinecraftProfileTexture.Type, MinecraftProfileTexture> getProfileTextures(GameProfile profile);
CompletableFuture<SkinUploadResponse> uploadSkin(Session session, @Nullable URI image, MinecraftProfileTexture.Type type, Map<String, String> metadata); CompletableFuture<SkinUploadResponse> uploadSkin(Session session, @Nullable URI image, MinecraftProfileTexture.Type type, Map<String, String> metadata);