Commit graph

549 commits

Author SHA1 Message Date
Patrick Gotthard
af93948e78 Merge pull request #304 from mishako/cleanup
Cleanup
2016-06-20 08:20:52 +02:00
mishako
29b992ba02 Combine all .gitignore files into a single one 2016-06-19 18:39:34 +02:00
mishako
d2cc166afa Delete readme files inside modules
They don't provide any additional information to what we already have in
the root readme file.
2016-06-19 18:39:33 +02:00
mishako
baa13b578e Remove license file inside modules
We already have a license file in the root.
2016-06-19 18:39:33 +02:00
mishako
f0b12ab41e Delete license header example file
License header can be copied from one of the existing files, no need
for a separate template file.
2016-06-19 18:39:33 +02:00
mishako
a6a20c3012 Remove commented out logger calls 2016-06-19 18:39:33 +02:00
mishako
ac7d9c83b5 Remove useless comments
Removed:
 * Empty comments
 * Empty @param and @return tags
 * Comments explaining how Java constructors work
 * Comments copy-pasted from parent classes
 * Comments begging to write documentation
2016-06-19 17:35:00 +02:00
mishako
c36bfd8f47 Remove @version and @author tags
Since we don't have any convention for how to use @version it's best to
avoid it completely. As for the @author tag, it is considered redundant
nowadays because this information is in the version control system.
2016-06-19 17:34:54 +02:00
mishako
6f6ff0ddd5 Remove LGPL license headers
Dual-licensing allows us to choose any of the licenses. Since the rest
of the project is licensed under the Apache license it makes sense to
remove LGPL altogether.

`CustomTagImpl.java` and `DurationTest.java` didn't have Apache license
header, but I assume they were supposed to, judging from Robert's email
from 5 Aug 2010 on the Rome dev mailing list: "Well, all those files are
things I moved from my other project. If the license headers weren't
changed, it was simply because of an oversight on my part".
2016-06-19 17:34:44 +02:00
mishako
0993a6a10c Remove license info from package.html files
We already have license headers in all java files, no need to include
it in package descriptions.
2016-06-19 17:34:19 +02:00
Patrick Gotthard
961a6407e1 Merge pull request #293 from mishako/try-catch-duration
Catch itunes duration parsing exceptions
2016-06-11 07:47:38 +02:00
mishako
943c0db298 Catch itunes duration parsing exceptions
Parsing of a malformed or empty duration resulted in an uncaught
exception that was breaking feed parsing completely. We already catch
exceptions when parsing other fields, e.g. href attribute of the image
tag. Also, it's more user-friendly to handle malformed data instead of
failing everything.
2016-06-10 21:00:01 +02:00
Patrick Gotthard
3c681bd4ae Merge pull request #300 from mishako/xml-parser-feature-fix
Do not set unsupported XML parser features
2016-05-01 12:42:11 +02:00
mishako
6920ff0fbe Do not set unsupported XML parser features
Fixes bug introduced in 2bc58a0. The call to `XMLReader::setFeature`
is used to check if the feature is supported and must happen before
`SAXBuilder::setFeature`. Otherwise XML parsing throws an exception.

The change is not tested, because it is exceptionally cumbersome to
test unsupported features. Possible ways to do it include using an
existing XML library that is known to not support features that the
code is trying to set, or implementing a mock XML parser that doesn't
support any features at all. It's hard to include an XML library
without interfering with other tests and it's hard to implement a mock
XML parser.

Fixes #294
2016-04-30 21:43:48 +02:00
mishako
63ce6584f4 Merge pull request #296 from rchakra3/NumberParserTests
Added tests for NumberParser
2016-04-27 22:27:06 +02:00
Rohan Chakravarthy
e13c27471e Added tests for NumberParser 2016-04-27 16:20:56 -04:00
Patrick Gotthard
f07562f94d Fixes Jenkinsfile
Updates Jenkinsfile to trigger SCM checkout and Maven build
2016-04-26 21:02:22 +02:00
Patrick Gotthard
eb2f5f1258 Add Jenkinsfile 2016-04-26 20:34:54 +02:00
Patrick Gotthard
d1456ace4a Merge pull request #297 from mishako/maven-site-cleanup
Maven site cleanup
2016-04-24 19:42:14 +02:00
mishako
0fed3b4bb6 Remove mentions of old versions from the site 2016-04-24 12:29:44 +02:00
mishako
eb917277b6 Remove mentions of Java 1.4 from the site 2016-04-23 23:28:55 +02:00
mishako
23a5e7990b Clean up site index page 2016-04-23 23:25:15 +02:00
mishako
70af49f938 Slightly improve layout of the site 2016-04-23 21:12:25 +02:00
mishako
e6732b88e1 Fix links to subprojects on site index page 2016-04-23 20:38:33 +02:00
mishako
083a5d32d5 Combine all maven sites into one 2016-04-10 17:38:37 +02:00
Patrick Gotthard
874a0c89a7 Merge pull request #290 from bibliolabs/master
Adds missing entry 'rights' to Atom 1.0 generator output
2016-04-09 08:25:43 +02:00
Patrick Gotthard
932f0546dc Merge pull request #292 from mishako/dc-date-test-rewrite
Rewrite dublin core date test
2016-04-09 08:25:12 +02:00
mishako
15a5f15ed0 Rewrite dublin core date test
Original code had a copyright notice and no license header. Completely
rewriting the code is one of the ways to make sure the code is licensed
under Apache license.
2016-03-31 22:11:23 +02:00
mishako
94861b0532 Merge pull request #291 from puntogil/master
fix license headers
2016-03-30 21:10:26 +02:00
gil
a090ed9b24 fix license headers 2016-03-30 01:43:42 +02:00
Michael Atwood
7bbcce50d1 Added missing entry 'rights' to Atom 1.0 generator output. 2016-03-29 09:48:32 -04:00
mishako
9aa69bf607 Merge pull request #283 from sagen/flexible_filesize
Parse units in filesizes in Media RSS
2016-03-28 23:00:04 +02:00
alesagen
9b45f200af Parse units in filesizes in Media RSS 2016-03-28 22:55:34 +02:00
Patrick Gotthard
e91a99ccea Merge pull request #284 from DevFactory/release/adding-private-constructor-fix-1
Utility classes should not have public constructors
2016-03-23 22:10:27 +01:00
ayman abdelghany
ce28559041 Utility classes should not have public constructors 2016-03-21 23:33:52 +02:00
Patrick Gotthard
a731362234 [maven-release-plugin] prepare for next development iteration 2016-03-11 14:50:53 +01:00
Patrick Gotthard
28fad6ad07 [maven-release-plugin] prepare release 1.6.0 2016-03-11 14:50:49 +01:00
Patrick Gotthard
b907f73a8e Disabled doclint 2016-03-11 14:39:26 +01:00
Patrick Gotthard
1fe72c7ad0 Updated format for tag names 2016-03-11 14:29:25 +01:00
mishako
0683b18cf4 Merge pull request #278 from rometools/release-config
POM configurations for next release to Maven Central
2016-03-09 21:45:42 +01:00
Patrick Gotthard
d4b8b14c88 Updating all windows line breaks (crlf) to unix line breaks (lf) 2016-03-06 08:51:57 +01:00
Patrick Gotthard
fe4fb3b4cd Fixed typo in description 2016-03-05 02:21:05 +01:00
Patrick Gotthard
30638903e9 POM configurations for next release to Maven Central 2016-03-05 02:12:27 +01:00
Patrick Gotthard
6f61c4f12e Added configuration for line endings 2016-03-05 02:00:13 +01:00
Patrick Gotthard
494cff6955 Added changelog for version 1.6.0 2016-03-04 23:56:45 +01:00
mishako
91da3003a1 Merge pull request #277 from rometools/ROME-276-fetcher-removal
#276 added deprecation notice to rome-fetcher
2016-03-04 23:29:51 +01:00
Patrick Gotthard
fdffe7d315 #276 added deprecation notice to rome-fetcher 2016-03-04 23:02:03 +01:00
mishako
b718922a53 Merge pull request #275 from rometools/ROME-234-fetcher-allowdoctypes
#234 Implemented possibility to allow doctype declarations using fetcher
2016-03-03 21:53:50 +01:00
Patrick Gotthard
a058deb267 Merge pull request #274 from mishako/rss-2-by-default
Use RSS2 parser as fallback when no version is set
2016-03-01 21:25:42 +01:00
mishako
deb781924e Use RSS v2 parser by default
Changed RSS v2 parser to match any feed that has "rss" as root element.
This makes Rome more lenient when handling feeds that don't adhere to
the RSS spec, namely have the "version" attribute missing.
2016-03-01 20:51:16 +01:00