From cae4df68bce98ac48b9cbe2d03bd896ad315c904 Mon Sep 17 00:00:00 2001 From: MareStare Date: Tue, 4 Mar 2025 04:49:44 +0000 Subject: [PATCH] Remove the no-longer needed `mouseMoveThenOver` utility --- assets/js/utils/__tests__/events.spec.ts | 59 +----------------------- assets/js/utils/events.ts | 11 ----- 2 files changed, 1 insertion(+), 69 deletions(-) diff --git a/assets/js/utils/__tests__/events.spec.ts b/assets/js/utils/__tests__/events.spec.ts index f53b22ce..00e2a5ee 100644 --- a/assets/js/utils/__tests__/events.spec.ts +++ b/assets/js/utils/__tests__/events.spec.ts @@ -1,12 +1,4 @@ -import { - delegate, - fire, - mouseMoveThenOver, - leftClick, - on, - PhilomenaAvailableEventsMap, - oncePersistedPageShown, -} from '../events'; +import { delegate, fire, leftClick, on, PhilomenaAvailableEventsMap, oncePersistedPageShown } from '../events'; import { getRandomArrayItem } from '../../../test/randomness'; import { fireEvent } from '@testing-library/dom'; @@ -88,55 +80,6 @@ describe('Event utils', () => { }); }); - describe('mouseMoveThenOver', () => { - it('should NOT fire on first mouseover', () => { - const mockButton = document.createElement('button'); - const mockHandler = vi.fn(); - - mouseMoveThenOver(mockButton, mockHandler); - - fireEvent.mouseOver(mockButton); - - expect(mockHandler).toHaveBeenCalledTimes(0); - }); - - it('should fire on the first mousemove', () => { - const mockButton = document.createElement('button'); - const mockHandler = vi.fn(); - - mouseMoveThenOver(mockButton, mockHandler); - - fireEvent.mouseMove(mockButton); - - expect(mockHandler).toHaveBeenCalledTimes(1); - }); - - it('should fire on subsequent mouseover', () => { - const mockButton = document.createElement('button'); - const mockHandler = vi.fn(); - - mouseMoveThenOver(mockButton, mockHandler); - - fireEvent.mouseMove(mockButton); - fireEvent.mouseOver(mockButton); - - expect(mockHandler).toHaveBeenCalledTimes(2); - }); - - it('should NOT fire on subsequent mousemove', () => { - const mockButton = document.createElement('button'); - const mockHandler = vi.fn(); - - mouseMoveThenOver(mockButton, mockHandler); - - fireEvent.mouseMove(mockButton); - fireEvent.mouseOver(mockButton); - fireEvent.mouseMove(mockButton); - - expect(mockHandler).toHaveBeenCalledTimes(2); - }); - }); - describe('oncePersistedPageShown', () => { it('should NOT fire on usual page show', () => { const mockHandler = vi.fn(); diff --git a/assets/js/utils/events.ts b/assets/js/utils/events.ts index f9d31c29..fa692fde 100644 --- a/assets/js/utils/events.ts +++ b/assets/js/utils/events.ts @@ -43,17 +43,6 @@ export function leftClick(func }; } -export function mouseMoveThenOver(element: El, func: (e: MouseEvent) => void) { - element.addEventListener( - 'mousemove', - (event: MouseEvent) => { - func(event); - element.addEventListener('mouseover', func); - }, - { once: true }, - ); -} - export function oncePersistedPageShown(func: (e: PageTransitionEvent) => void) { const controller = new AbortController();