diff --git a/lib/philomena/images.ex b/lib/philomena/images.ex index a0e90b6c..9feda6ab 100644 --- a/lib/philomena/images.ex +++ b/lib/philomena/images.ex @@ -153,9 +153,9 @@ defmodule Philomena.Images do end end - defp maybe_approve_image(image, nil), do: false + defp maybe_approve_image(_image, nil), do: false - defp maybe_approve_image(image, %User{verified: false, role: role}) when role == "user", + defp maybe_approve_image(_image, %User{verified: false, role: role}) when role == "user", do: false defp maybe_approve_image(image, _user), do: approve_image(image) diff --git a/lib/philomena_web/controllers/conversation/message/approve_controller.ex b/lib/philomena_web/controllers/conversation/message/approve_controller.ex index c45dc9ec..a5265a59 100644 --- a/lib/philomena_web/controllers/conversation/message/approve_controller.ex +++ b/lib/philomena_web/controllers/conversation/message/approve_controller.ex @@ -14,7 +14,6 @@ defmodule PhilomenaWeb.Conversation.Message.ApproveController do def create(conn, _params) do message = conn.assigns.message - user = conn.assigns.current_user {:ok, _message} = Conversations.approve_conversation_message(message) @@ -24,7 +23,7 @@ defmodule PhilomenaWeb.Conversation.Message.ApproveController do |> redirect(to: "/") end - defp log_details(conn, _action, message) do + defp log_details(_conn, _action, message) do %{ body: "Approved private message in conversation ##{message.conversation_id}", subject_path: "/" diff --git a/lib/philomena_web/controllers/topic/post/approve_controller.ex b/lib/philomena_web/controllers/topic/post/approve_controller.ex index 17a1a4b9..90bf3948 100644 --- a/lib/philomena_web/controllers/topic/post/approve_controller.ex +++ b/lib/philomena_web/controllers/topic/post/approve_controller.ex @@ -38,7 +38,7 @@ defmodule PhilomenaWeb.Topic.Post.ApproveController do end end - defp log_details(conn, action, post) do + defp log_details(conn, _action, post) do %{ body: "Approved forum post ##{post.id} in topic '#{post.topic.title}'", subject_path: diff --git a/lib/philomena_web/markdown_renderer.ex b/lib/philomena_web/markdown_renderer.ex index d8893467..97c63fb4 100644 --- a/lib/philomena_web/markdown_renderer.ex +++ b/lib/philomena_web/markdown_renderer.ex @@ -102,7 +102,7 @@ defmodule PhilomenaWeb.MarkdownRenderer do ) |> safe_to_string() - [id, suffix] when not img.approved -> + [_id, suffix] when not img.approved -> ">>#{img.id}#{suffix}#{link_suffix(img)}" [_id, ""] ->