From af97bd1717ada0e507477302db30b19fafc59653 Mon Sep 17 00:00:00 2001 From: "byte[]" Date: Sun, 5 Jan 2020 13:03:43 -0500 Subject: [PATCH] fix graph height calculation --- lib/philomena_web/views/stat_view.ex | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/philomena_web/views/stat_view.ex b/lib/philomena_web/views/stat_view.ex index 51dab742..7bf1d5b2 100644 --- a/lib/philomena_web/views/stat_view.ex +++ b/lib/philomena_web/views/stat_view.ex @@ -5,18 +5,19 @@ defmodule PhilomenaWeb.StatView do data = Enum.sort_by(data, & &1["key"]) n_buckets = length(data) - {%{"key" => min_time}, %{"key" => max_time}} = Enum.min_max_by(data, & &1["key"], fn -> %{"key" => 0} end) - {%{"doc_count" => min_docs}, %{"doc_count" => max_docs}} = Enum.min_max_by(data, & &1["doc_count"], fn -> %{"doc_count" => 0} end) + { + %{"doc_count" => min_docs}, + %{"doc_count" => max_docs} + } = Enum.min_max_by(data, & &1["doc_count"], fn -> %{"doc_count" => 0} end) graph_width = 950 graph_height = 475 bar_width = safe_div(graph_width, n_buckets) - max_bar_height = safe_div(graph_height, max_docs - min_docs) content_tag :svg, class: "upload-stats", viewBox: "0 0 #{graph_width} #{graph_height}" do for {datum, i} <- Enum.with_index(data) do - bar_height = safe_div(datum["doc_count"], max_docs) * max_bar_height + bar_height = safe_div(datum["doc_count"], max_docs) * graph_height x = i * bar_width y = graph_height-bar_height @@ -29,6 +30,6 @@ defmodule PhilomenaWeb.StatView do end end - defp safe_div(n, 0), do: 0 + defp safe_div(_n, 0), do: 0 defp safe_div(n, d), do: n / d end