From 417d34ef1a939fdf1857ba4eab4b2bcc235514e2 Mon Sep 17 00:00:00 2001 From: Sebastian Krzyszkowiak Date: Wed, 16 Aug 2017 01:47:07 +0200 Subject: [PATCH] fix stuff reported by static analyzer --- src/character.c | 1 - src/internal.c | 2 +- src/libsuperderpy.c | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/character.c b/src/character.c index ac3ea32..e203aaf 100644 --- a/src/character.c +++ b/src/character.c @@ -154,7 +154,6 @@ SYMBOL_EXPORT void DestroyCharacter(struct Game *game, struct Character *charact PrintConsole(game, "Destroying character %s...", character->name); if (!character->shared) { struct Spritesheet *tmp, *s = character->spritesheets; - tmp = s; while (s) { tmp = s; s = s->next; diff --git a/src/internal.c b/src/internal.c index a58add9..00c0d23 100644 --- a/src/internal.c +++ b/src/internal.c @@ -171,7 +171,7 @@ SYMBOL_INTERNAL struct libsuperderpy_list* AddToList(struct libsuperderpy_list * } SYMBOL_INTERNAL struct libsuperderpy_list* RemoveFromList(struct libsuperderpy_list **list, bool (*identity)(struct libsuperderpy_list* elem, void* data), void* data) { - struct libsuperderpy_list *prev = NULL, *tmp = *list, *start = *list; + struct libsuperderpy_list *prev = NULL, *tmp = *list, *start; void* d = NULL; while (tmp) { if (identity(tmp, data)) { diff --git a/src/libsuperderpy.c b/src/libsuperderpy.c index bfd2f37..a9d44ff 100644 --- a/src/libsuperderpy.c +++ b/src/libsuperderpy.c @@ -57,6 +57,7 @@ SYMBOL_EXPORT struct Game* libsuperderpy_init(int argc, char** argv, const char* if(!al_init()) { fprintf(stderr, "failed to initialize allegro!\n"); + free(game); return NULL; }