From 2c2c5ef766316811083f91166ee3d7e9c26f6391 Mon Sep 17 00:00:00 2001 From: Joakim Soderlund Date: Sun, 29 Mar 2020 16:22:20 +0200 Subject: [PATCH] Remove fixture for dummy fetcher --- tests/tasks/conftest.py | 10 ---------- tests/tasks/test_update.py | 11 ++++++----- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/tests/tasks/conftest.py b/tests/tasks/conftest.py index 5045004..918e9ed 100644 --- a/tests/tasks/conftest.py +++ b/tests/tasks/conftest.py @@ -24,8 +24,6 @@ Common task fixtures. from typing import Dict -import pytest - from fimfarchive.exceptions import InvalidStoryError from fimfarchive.fetchers import Fetcher from fimfarchive.stories import Story @@ -71,11 +69,3 @@ class DummyFetcher(Fetcher): return self.stories[key] except KeyError: raise InvalidStoryError() - - -@pytest.fixture -def dummy() -> DummyFetcher: - """ - Returns a `Fetcher` dummy. - """ - return DummyFetcher() diff --git a/tests/tasks/test_update.py b/tests/tasks/test_update.py index 70f0705..5d28493 100644 --- a/tests/tasks/test_update.py +++ b/tests/tasks/test_update.py @@ -22,7 +22,6 @@ Update task tests. # -from copy import deepcopy from unittest.mock import MagicMock, call, patch import pytest @@ -34,6 +33,8 @@ from fimfarchive.tasks.update import ( UpdateTask, SUCCESS_DELAY, SKIPPED_DELAY, FAILURE_DELAY, ) +from .conftest import DummyFetcher + class TestUpdateTask: """ @@ -41,18 +42,18 @@ class TestUpdateTask: """ @pytest.fixture - def fimfiction(self, dummy): + def fimfiction(self): """ Returns a `Fetcher` simulating Fimfiction. """ - return deepcopy(dummy) + return DummyFetcher() @pytest.fixture - def fimfarchive(self, dummy): + def fimfarchive(self): """ Returns a `Fetcher` simulating Fimfarchive. """ - return deepcopy(dummy) + return DummyFetcher() @pytest.fixture def selector(self):