From 0ee7e4a315a9916c60708aaf73d6af2cbed819ed Mon Sep 17 00:00:00 2001
From: Kelvin <hello@iamkelv.in>
Date: Mon, 11 Jul 2016 13:40:31 +0100
Subject: [PATCH] #7: Implement front-end handling of mixed losslessness track
 collections

---
 app/Models/Album.php                             |  3 ++-
 app/Models/Playlist.php                          |  3 ++-
 public/templates/albums/show.html                |  4 ++--
 .../collection-mixed-losslessness-dialog.html    | 16 ++++++++++++++++
 public/templates/playlists/show.html             |  4 ++--
 .../assets/scripts/app/controllers/album.coffee  |  9 ++++++++-
 .../scripts/app/controllers/playlist.coffee      |  9 ++++++++-
 7 files changed, 40 insertions(+), 8 deletions(-)
 create mode 100644 public/templates/partials/collection-mixed-losslessness-dialog.html

diff --git a/app/Models/Album.php b/app/Models/Album.php
index 4ce398f1..876e9ca2 100644
--- a/app/Models/Album.php
+++ b/app/Models/Album.php
@@ -152,7 +152,8 @@ class Album extends Model implements Searchable, Commentable, Favouritable
                 'extension' => $format['extension'],
                 'url' => $album->getDownloadUrl($name),
                 'size' => Helpers::formatBytes($album->getFilesize($name)),
-                'isCacheable' => (in_array($name, Track::$CacheableFormats) ? true : false)
+                'isCacheable' => (in_array($name, Track::$CacheableFormats) ? true : false),
+                'isMixedLosslessness' => (in_array($name, Track::$LosslessFormats) && !$album->hasLosslessTracksOnly() && $album->hasLosslessTracks())
             ];
         }
         
diff --git a/app/Models/Playlist.php b/app/Models/Playlist.php
index 3fea8ecf..f2639a3f 100644
--- a/app/Models/Playlist.php
+++ b/app/Models/Playlist.php
@@ -127,7 +127,8 @@ class Playlist extends Model implements Searchable, Commentable, Favouritable
                 'extension' => $format['extension'],
                 'url' => $playlist->getDownloadUrl($name),
                 'size' => Helpers::formatBytes($playlist->getFilesize($name)),
-                'isCacheable' => (in_array($name, Track::$CacheableFormats) ? true : false)
+                'isCacheable' => (in_array($name, Track::$CacheableFormats) ? true : false),
+                'isMixedLosslessness' => (in_array($name, Track::$LosslessFormats) && !$playlist->hasLosslessTracksOnly() && $playlist->hasLosslessTracks())
             ];
         }
 
diff --git a/public/templates/albums/show.html b/public/templates/albums/show.html
index b7f520ca..710368ed 100644
--- a/public/templates/albums/show.html
+++ b/public/templates/albums/show.html
@@ -6,11 +6,11 @@
             </a>
             <ul class="dropdown-menu" ng-show="::album.is_downloadable == 1">
                 <li ng-repeat="format in ::album.formats" ng-hide="isInProgress">
-                    <a target="_blank" ng-if="::!format.isCacheable" ng-href="{{::format.url}}">
+                    <a target="_blank" ng-if="::!format.isCacheable" ng-click="checkMixedLosslessness(format);" ng-href="{{::format.url}}">
                         <span>{{::format.name}}</span>
                         <small>({{::format.size}})</small>
                     </a>
-                    <a ng-if="::format.isCacheable" ng-click="getCachedAlbum(album.id, format.name);" href="">
+                    <a ng-if="::format.isCacheable" ng-click="getCachedAlbum(album.id, format);" href="">
                         <span>{{::format.name}}</span>
                         <small>({{::format.size}})</small>
                     </a>
diff --git a/public/templates/partials/collection-mixed-losslessness-dialog.html b/public/templates/partials/collection-mixed-losslessness-dialog.html
new file mode 100644
index 00000000..0d5e0e87
--- /dev/null
+++ b/public/templates/partials/collection-mixed-losslessness-dialog.html
@@ -0,0 +1,16 @@
+<div class="modal" tabindex="-1" role="dialog">
+    <div class="modal-dialog">
+        <div class="modal-content">
+            <div class="modal-header" ng-show="title">
+                <button type="button" class="close" ng-click="$hide()">&times;</button>
+                <h4 class="modal-title">Information</h4>
+            </div>
+            <div class="modal-body">
+                <p>Your download contains some tracks which are in lossy formats instead of your chosen lossless format ({{::format.name}}. This is because they were originally uploaded in a lossy format (e.g., MP3). As a result, these tracks have been replaced by their lossy files.</p>
+            </div>
+            <div class="modal-footer">
+                <button type="button" class="btn btn-primary" ng-click="$hide()">OK</button>
+            </div>
+        </div>
+    </div>
+</div>
diff --git a/public/templates/playlists/show.html b/public/templates/playlists/show.html
index 98a933ee..b236d34e 100644
--- a/public/templates/playlists/show.html
+++ b/public/templates/playlists/show.html
@@ -6,11 +6,11 @@
             </a>
             <ul class="dropdown-menu">
                 <li ng-repeat="format in ::playlist.formats" ng-hide="isInProgress">
-                    <a target="_blank" ng-if="::!format.isCacheable" ng-href="{{::format.url}}">
+                    <a target="_blank" ng-if="::!format.isCacheable" ng-click="checkMixedLosslessness(format);" ng-href="{{::format.url}}">
                         <span>{{::format.name}}</span>
                         <small>({{::format.size}})</small>
                     </a>
-                    <a ng-if="::format.isCacheable" ng-click="getCachedPlaylist(playlist.id, format.name);" href="">
+                    <a ng-if="::format.isCacheable" ng-click="getCachedPlaylist(playlist.id, format);" href="">
                         <span>{{::format.name}}</span>
                         <small>({{::format.size}})</small>
                     </a>
diff --git a/resources/assets/scripts/app/controllers/album.coffee b/resources/assets/scripts/app/controllers/album.coffee
index 18cc6717..fd979cc3 100644
--- a/resources/assets/scripts/app/controllers/album.coffee
+++ b/resources/assets/scripts/app/controllers/album.coffee
@@ -43,10 +43,16 @@ module.exports = angular.module('ponyfm').controller "album", [
             playlists.refreshOwned().done (lists) ->
                 $scope.playlists.push list for list in lists
 
+        $scope.checkMixedLosslessness = (format) ->
+            if format.isMixedLosslessness == true
+                $scope.format = format
+                $modal({scope: $scope, templateUrl: 'templates/partials/collection-mixed-losslessness-dialog.html', show: true})
+
+
         $scope.getCachedAlbum = (id, format) ->
             $scope.isInProgress = true
 
-            cachedAlbum.download('albums', id, format).then (response) ->
+            cachedAlbum.download('albums', id, format.name).then (response) ->
                 $scope.albumUrl = response
                 if $scope.albumUrl == 'error'
                     $scope.isInProgress = false
@@ -59,4 +65,5 @@ module.exports = angular.module('ponyfm').controller "album", [
                 else
                     $scope.isInProgress = false
                     $window.open $scope.albumUrl
+                    $scope.checkMixedLosslessness(format)
 ]
diff --git a/resources/assets/scripts/app/controllers/playlist.coffee b/resources/assets/scripts/app/controllers/playlist.coffee
index 06acbc29..da2fb71f 100644
--- a/resources/assets/scripts/app/controllers/playlist.coffee
+++ b/resources/assets/scripts/app/controllers/playlist.coffee
@@ -37,10 +37,16 @@ module.exports = angular.module('ponyfm').controller 'playlist', [
                 controller: ['$scope', ($scope) -> $scope.playlist = playlist; $scope.close = () -> dialog.close()],
                 show: true
 
+        $scope.checkMixedLosslessness = (format) ->
+            if format.isMixedLosslessness == true
+                $scope.format = format
+                $modal({scope: $scope, templateUrl: 'templates/partials/collection-mixed-losslessness-dialog.html', show: true})
+
+            
         $scope.getCachedPlaylist = (id, format) ->
             $scope.isInProgress = true
 
-            cachedPlaylist.download('playlists', id, format).then (response) ->
+            cachedPlaylist.download('playlists', id, format.name).then (response) ->
                 $scope.playlistUrl = response
                 if $scope.playlistUrl == 'error'
                     $scope.isInProgress = false
@@ -53,4 +59,5 @@ module.exports = angular.module('ponyfm').controller 'playlist', [
                 else
                     $scope.isInProgress = false
                     $window.open $scope.playlistUrl
+                    $scope.checkMixedLosslessness(format)
 ]