From 0000c4297d6b8518212318b277a26975d1aabc55 Mon Sep 17 00:00:00 2001
From: nelsonlaquet <nelsonlaquet@gmail.com>
Date: Sun, 1 Sep 2013 16:54:33 -0500
Subject: [PATCH] Added cute error pages

---
 app/controllers/Api/Web/ArtistsController.php   |  1 +
 app/filters.php                                 |  9 +++++++++
 app/models/Entities/Image.php                   |  2 +-
 app/models/Entities/Track.php                   |  2 +-
 app/views/errors/400.blade.php                  | 12 ++++++++++++
 app/views/errors/403.blade.php                  | 12 ++++++++++++
 app/views/errors/404.blade.php                  | 12 ++++++++++++
 app/views/errors/500.blade.php                  | 12 ++++++++++++
 app/views/shared/_app_layout.blade.php          |  4 ++--
 public/scripts/app/app.coffee                   | 17 +++++++++++++++++
 .../scripts/app/controllers/application.coffee  | 10 ++++++++--
 .../app/controllers/artist-content.coffee       |  5 +++--
 public/scripts/app/controllers/artist.coffee    |  5 +++--
 public/scripts/app/services/artists.coffee      | 14 ++++++++++----
 public/templates/errors/400.html                |  3 +++
 public/templates/errors/403.html                |  3 +++
 public/templates/errors/404.html                |  3 +++
 public/templates/errors/500.html                |  3 +++
 18 files changed, 115 insertions(+), 14 deletions(-)
 create mode 100644 app/views/errors/400.blade.php
 create mode 100644 app/views/errors/403.blade.php
 create mode 100644 app/views/errors/404.blade.php
 create mode 100644 app/views/errors/500.blade.php
 create mode 100644 public/templates/errors/400.html
 create mode 100644 public/templates/errors/403.html
 create mode 100644 public/templates/errors/404.html
 create mode 100644 public/templates/errors/500.html

diff --git a/app/controllers/Api/Web/ArtistsController.php b/app/controllers/Api/Web/ArtistsController.php
index dd3e0017..3dfaee41 100644
--- a/app/controllers/Api/Web/ArtistsController.php
+++ b/app/controllers/Api/Web/ArtistsController.php
@@ -14,6 +14,7 @@
 	use Entities\Image;
 	use Entities\Track;
 	use Entities\User;
+	use Illuminate\Support\Facades\App;
 	use Illuminate\Support\Facades\Auth;
 	use Illuminate\Support\Facades\Input;
 	use Illuminate\Support\Facades\Response;
diff --git a/app/filters.php b/app/filters.php
index 622380bb..0456d3a0 100644
--- a/app/filters.php
+++ b/app/filters.php
@@ -40,6 +40,15 @@
 		});
 	}
 
+	App::error(function($exception) {
+		return Response::view('errors.404', array(), 404);
+	});
+
+	App::missing(function($exception) {
+		return Response::view('errors.404', array(), 404);
+	});
+
+
 	/*
 	|--------------------------------------------------------------------------
 	| Authentication Filters
diff --git a/app/models/Entities/Image.php b/app/models/Entities/Image.php
index 7c765612..2ffb3adc 100644
--- a/app/models/Entities/Image.php
+++ b/app/models/Entities/Image.php
@@ -94,6 +94,6 @@
 			$destination = $this->getDirectory();
 
 			if (!is_dir($destination))
-				mkdir($destination, 755, true);
+				mkdir($destination, 777, true);
 		}
 	}
\ No newline at end of file
diff --git a/app/models/Entities/Track.php b/app/models/Entities/Track.php
index 32490d1d..13a9ae3e 100644
--- a/app/models/Entities/Track.php
+++ b/app/models/Entities/Track.php
@@ -328,7 +328,7 @@
 			$destination = $this->getDirectory();
 
 			if (!is_dir($destination))
-				mkdir($destination, 755);
+				mkdir($destination, 777);
 		}
 
 		public function hasCover() {
diff --git a/app/views/errors/400.blade.php b/app/views/errors/400.blade.php
new file mode 100644
index 00000000..bfc98077
--- /dev/null
+++ b/app/views/errors/400.blade.php
@@ -0,0 +1,12 @@
+@extends('shared._app_layout')
+
+@section('app_content')
+	<h1>400 - Invalid Request</h1>
+	<p>Your request was invalid.</p>
+@endsection
+
+@section('app_scripts')
+	<script>
+		window.pfm.error = 400;
+	</script>
+@endsection
\ No newline at end of file
diff --git a/app/views/errors/403.blade.php b/app/views/errors/403.blade.php
new file mode 100644
index 00000000..3c1d4e61
--- /dev/null
+++ b/app/views/errors/403.blade.php
@@ -0,0 +1,12 @@
+@extends('shared._app_layout')
+
+@section('app_content')
+	<h1>403 - Not Authorized</h1>
+	<p>You cannot do this.</p>
+@endsection
+
+@section('app_scripts')
+	<script>
+		window.pfm.error = 403;
+	</script>
+@endsection
\ No newline at end of file
diff --git a/app/views/errors/404.blade.php b/app/views/errors/404.blade.php
new file mode 100644
index 00000000..05b9d0ed
--- /dev/null
+++ b/app/views/errors/404.blade.php
@@ -0,0 +1,12 @@
+@extends('shared._app_layout')
+
+@section('app_content')
+	<h1>404 - Not Found</h1>
+	<p>We could not find what you were looking for.</p>
+@endsection
+
+@section('app_scripts')
+	<script>
+		window.pfm.error = 404;
+	</script>
+@endsection
\ No newline at end of file
diff --git a/app/views/errors/500.blade.php b/app/views/errors/500.blade.php
new file mode 100644
index 00000000..809aac05
--- /dev/null
+++ b/app/views/errors/500.blade.php
@@ -0,0 +1,12 @@
+@extends('shared._app_layout')
+
+@section('app_content')
+	<h1>400 - Server Error</h1>
+	<p>There was an error in the server.</p>
+@endsection
+
+@section('app_scripts')
+	<script>
+		window.pfm.error = 500;
+	</script>
+@endsection
\ No newline at end of file
diff --git a/app/views/shared/_app_layout.blade.php b/app/views/shared/_app_layout.blade.php
index 2e2cf9c9..1cab25e0 100644
--- a/app/views/shared/_app_layout.blade.php
+++ b/app/views/shared/_app_layout.blade.php
@@ -92,7 +92,6 @@
 @endsection
 
 @section('scripts')
-
 	<script>
 		window.pfm = {
 			token: "{{Session::token()}}",
@@ -112,7 +111,6 @@
 		var _gaq = _gaq || [];
 		_gaq.push(['_setAccount', 'UA-29463256-1']);
 		_gaq.push(['_setDomainName', 'pony.fm']);
-		_gaq.push(['_trackPageview']);
 
 		(function() {
 			var ga = document.createElement('script'); ga.type = 'text/javascript'; ga.async = true;
@@ -123,4 +121,6 @@
 
 	{{ Assets::scriptIncludes() }}
 
+	@yield('app_scripts')
+
 @endsection
\ No newline at end of file
diff --git a/public/scripts/app/app.coffee b/public/scripts/app/app.coffee
index 5ad82256..0f45ba2e 100644
--- a/public/scripts/app/app.coffee
+++ b/public/scripts/app/app.coffee
@@ -22,6 +22,23 @@ module.config [
 
 		analytics.setEventHandlers ['Google']
 
+		# Errors
+		state.state 'errors-404',
+			url: '/errors/not-found'
+			templateUrl: '/templates/errors/404.html'
+
+		state.state 'errors-500',
+			url: '/errors/server'
+			templateUrl: '/templates/errors/500.html'
+
+		state.state 'errors-403',
+			url: '/errors/not-authorized'
+			templateUrl: '/templates/errors/403.html'
+
+		state.state 'errors-400',
+			url: '/errors/invalid'
+			templateUrl: '/templates/errors/400.html'
+
 		# Upload
 
 		state.state 'uploader',
diff --git a/public/scripts/app/controllers/application.coffee b/public/scripts/app/controllers/application.coffee
index 98a48511..501414d2 100644
--- a/public/scripts/app/controllers/application.coffee
+++ b/public/scripts/app/controllers/application.coffee
@@ -8,6 +8,9 @@ angular.module('ponyfm').controller "application", [
 		$loadingElement = null
 		loadingStateName = null
 
+		if window.pfm.error
+			$state.transitionTo 'errors-' + window.pfm.error
+
 		$rootScope.safeApply = (fn) ->
 			phase = $rootScope.$$phase
 			if (phase == '$apply' || phase == 'digest')
@@ -73,7 +76,10 @@ angular.module('ponyfm').controller "application", [
 
 			stateToInject = angular.copy newState
 			stateToInject.params = newParams
-			$injector.invoke(preloader, null, {$state: stateToInject}).then ->
-				statesPreloaded[newState] = true
+			try
+				$injector.invoke(preloader, null, {$state: stateToInject}).then ->
+					statesPreloaded[newState] = true
+					$state.transitionTo newState, newParams
+			catch error
 				$state.transitionTo newState, newParams
 ]
\ No newline at end of file
diff --git a/public/scripts/app/controllers/artist-content.coffee b/public/scripts/app/controllers/artist-content.coffee
index 3ff4f489..9cd93197 100644
--- a/public/scripts/app/controllers/artist-content.coffee
+++ b/public/scripts/app/controllers/artist-content.coffee
@@ -7,6 +7,7 @@ window.pfm.preloaders['artist-content'] = [
 angular.module('ponyfm').controller "artist-content", [
 	'$scope', 'artists', '$state'
 	($scope, artists, $state) ->
-		artists.fetchContent($state.params.slug).done (artistResponse) ->
-			$scope.content = artistResponse
+		artists.fetchContent($state.params.slug)
+			.done (artistResponse) ->
+				$scope.content = artistResponse
 ]
\ No newline at end of file
diff --git a/public/scripts/app/controllers/artist.coffee b/public/scripts/app/controllers/artist.coffee
index c69f644c..0b51c66e 100644
--- a/public/scripts/app/controllers/artist.coffee
+++ b/public/scripts/app/controllers/artist.coffee
@@ -7,8 +7,9 @@ window.pfm.preloaders['artist'] = [
 angular.module('ponyfm').controller "artist", [
 	'$scope', 'artists', '$state', 'follow'
 	($scope, artists, $state, follow) ->
-		artists.fetch($state.params.slug).done (artistResponse) ->
-			$scope.artist = artistResponse.artist
+		artists.fetch($state.params.slug)
+			.done (artistResponse) ->
+				$scope.artist = artistResponse.artist
 
 		$scope.toggleFollow = () ->
 			follow.toggle('artist', $scope.artist.id).then (res) ->
diff --git a/public/scripts/app/services/artists.coffee b/public/scripts/app/services/artists.coffee
index 60890ff8..b3e8ee27 100644
--- a/public/scripts/app/services/artists.coffee
+++ b/public/scripts/app/services/artists.coffee
@@ -25,8 +25,11 @@ angular.module('ponyfm').factory('artists', [
 				slug = 1 if !slug
 				return artists[slug] if !force && artists[slug]
 				artistsDef = new $.Deferred()
-				$http.get('/api/web/artists/' + slug).success (albums) ->
-					artistsDef.resolve albums
+				$http.get('/api/web/artists/' + slug)
+					.success (albums) ->
+						artistsDef.resolve albums
+					.catch () ->
+						artistsDef.reject()
 
 				artists[slug] = artistsDef.promise()
 
@@ -35,8 +38,11 @@ angular.module('ponyfm').factory('artists', [
 				slug = 1 if !slug
 				return artistContent[slug] if !force && artistContent[slug]
 				artistsDef = new $.Deferred()
-				$http.get('/api/web/artists/' + slug + '/content').success (albums) ->
-					artistsDef.resolve albums
+				$http.get('/api/web/artists/' + slug + '/content')
+					.success (albums) ->
+						artistsDef.resolve albums
+					.catch () ->
+						artistsDef.reject()
 
 				artistContent[slug] = artistsDef.promise()
 
diff --git a/public/templates/errors/400.html b/public/templates/errors/400.html
new file mode 100644
index 00000000..c1c1601b
--- /dev/null
+++ b/public/templates/errors/400.html
@@ -0,0 +1,3 @@
+<h1>Twilight Sparkle burns with the rage of 400 suns.</h1>
+<p>The request you sent was not properly formed. Unfortunately, this means it had to be rejected.</p>
+<p>There isn&#39;t much you can do here, but perhaps you would like to go to our <a href="/">home page</a>?</p>
diff --git a/public/templates/errors/403.html b/public/templates/errors/403.html
new file mode 100644
index 00000000..47a7ef80
--- /dev/null
+++ b/public/templates/errors/403.html
@@ -0,0 +1,3 @@
+<h1>403 Royal Guards stand in your way.</h1>
+<p>Looks like you tried to do something you weren&#39;t allowed to!</p>
+<p>There isn&#39;t much you can do here, but perhaps you would like to go to our <a href="/">home page</a>?</p>
diff --git a/public/templates/errors/404.html b/public/templates/errors/404.html
new file mode 100644
index 00000000..47073e39
--- /dev/null
+++ b/public/templates/errors/404.html
@@ -0,0 +1,3 @@
+<h1>404 parasprites invaded the town!</h1>
+<p>We couldn&#39;t track down the page you were looking for! Perhaps a parasprite has eaten it, or it may never have existed in the first place. It&#39;s also possible that Princess Celestia banished it to the moon for heresy.</p>
+<p>In any case, we&#39;re sorry this happened. Perhaps you would like to go to our <a href="/">home page</a>?</p>
\ No newline at end of file
diff --git a/public/templates/errors/500.html b/public/templates/errors/500.html
new file mode 100644
index 00000000..821737f8
--- /dev/null
+++ b/public/templates/errors/500.html
@@ -0,0 +1,3 @@
+<h1>500 buckets of oats on the wall.</h1>
+<p>Something went wrong on our servers while we were processing your request. We're really sorry about this, and will work hard to get this resolved as	soon as possible.</p>
+<p>In any case, we&#39;re sorry this happened. Perhaps you would like to go to our <a href="/">home page</a>?</p>
\ No newline at end of file