From 5ab8126b70f245fc946dfa496b422f08d4542b13 Mon Sep 17 00:00:00 2001 From: Sollace Date: Mon, 3 Sep 2018 19:24:53 +0200 Subject: [PATCH] The result shouldn't be null, and if it is null you REALLY SHOULDN'T LOOP ON IT INDEFINITELY --- .../java/com/voxelmodpack/hdskins/HDSkinManager.java | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/hdskins/java/com/voxelmodpack/hdskins/HDSkinManager.java b/src/hdskins/java/com/voxelmodpack/hdskins/HDSkinManager.java index ed3f0a1b..077995d7 100644 --- a/src/hdskins/java/com/voxelmodpack/hdskins/HDSkinManager.java +++ b/src/hdskins/java/com/voxelmodpack/hdskins/HDSkinManager.java @@ -294,12 +294,8 @@ public final class HDSkinManager implements IResourceManagerReloadListener { public void parseSkin(GameProfile profile, Type type, ResourceLocation resource, MinecraftProfileTexture texture) { - // TODO: Infinite loop // The texture needs to be loaded in order to be parsed. - ITextureObject ito = null; - while (ito == null) { - ito = Minecraft.getMinecraft().getTextureManager().getTexture(resource); - } + Minecraft.getMinecraft().getTextureManager().getTexture(resource); // grab the metadata object via reflection. Object is live. Map metadata = ProfileTextureUtil.getMetadata(texture);