PatchesAndForks/rome
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #274 from mishako/rss-2-by-default

Browse source 
Use RSS2 parser as fallback when no version is set
This commit is contained in:
Patrick Gotthard 2016-03-01 21:25:42 +01:00
commit a058deb267
2 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
rome/src/main/java/com/rometools/rome/io/impl/RSS20Parser.java
View file

@ -51,7 +51,8 @@ public class RSS20Parser extends RSS094Parser {
@Override @Override
public boolean isMyType(final Document document) { public boolean isMyType(final Document document) {
return rootElementMatches(document) && versionMatches(document); return rootElementMatches(document)
&& (versionMatches(document) || versionAbsent(document));
} }
private boolean rootElementMatches(final Document document) { private boolean rootElementMatches(final Document document) {
@ -63,4 +64,8 @@ public class RSS20Parser extends RSS094Parser {
return (version != null) return (version != null)
&& version.getValue().trim().startsWith(getRSSVersion()); && version.getValue().trim().startsWith(getRSSVersion());
} }
private boolean versionAbsent(final Document document) {
return document.getRootElement().getAttribute("version") == null;
}
} }

6
rome/src/test/java/com/rometools/rome/io/impl/RSS20ParserTest.java
View file

@ -44,4 +44,10 @@ public class RSS20ParserTest {
document.setRootElement(new Element("rss").setAttribute("version", "2.0test")); document.setRootElement(new Element("rss").setAttribute("version", "2.0test"));
assertTrue(parser.isMyType(document)); assertTrue(parser.isMyType(document));
} }
@Test
public void testIsMyTypeVersionAbsent() {
document.setRootElement(new Element("rss"));
assertTrue(parser.isMyType(document));
}
} }