PatchesAndForks/rome
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Added test for issue 7

Browse source
This commit is contained in:
Patrick Gotthard 2014-04-18 19:44:23 +02:00
parent 6831f8a4af
commit 6b3ceb1cd7
2 changed files with 46 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
src/test/java/org/rometools/feed/module/mediarss/MediaModuleTest.java
View file

@ -7,6 +7,10 @@
package org.rometools.feed.module.mediarss;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.is;
import static org.hamcrest.Matchers.notNullValue;
import java.io.BufferedWriter;
import java.io.File;
import java.io.FileWriter;
@ -18,6 +22,7 @@ import junit.framework.TestSuite;
import org.rometools.feed.module.AbstractTestCase;
import org.rometools.feed.module.mediarss.types.MediaContent;
import org.rometools.feed.module.mediarss.types.Thumbnail;
import com.sun.syndication.feed.synd.SyndEntry;
import com.sun.syndication.feed.synd.SyndFeed;
@ -85,13 +90,33 @@ public class MediaModuleTest extends AbstractTestCase {
}
/**
* test url with whitespace in media element (https://github.com/rometools/rome-modules/issues/20).
* test url with whitespace in media element
* (https://github.com/rometools/rome-modules/issues/7).
*
* @throws IOException if file not found or not accessible
* @throws FeedException when the feed can't be parsed
*
*/
public void testParseThumbnailWithEmptyDimensions() throws FeedException, IOException {
final SyndFeed feed = getSyndFeed("org/rometools/feed/module/mediarss/issue-07.xml");
final SyndEntry entry = feed.getEntries().get(0);
final MediaEntryModule module = (MediaEntryModule) entry.getModule(MediaEntryModule.URI);
final Thumbnail[] thumbnails = module.getMetadata().getThumbnail();
assertThat(thumbnails, is(notNullValue()));
}
/**
* test url with whitespace in media element
* (https://github.com/rometools/rome-modules/issues/20).
*
* @throws Exception if file not found or not accessible
*/
public void testParseMediaContentContainingURLWithSpaces() throws Exception {
final SyndFeed feed = getSyndFeed(new File(getTestFile("org/rometools/feed/module/mediarss/issue-20.xml")));
final SyndEntry entry = (SyndEntry) feed.getEntries().get(0);
final SyndFeed feed = getSyndFeed("org/rometools/feed/module/mediarss/issue-20.xml");
final SyndEntry entry = feed.getEntries().get(0);
final MediaEntryModule m = (MediaEntryModule) entry.getModule(MediaEntryModule.URI);
assertNotNull("missing media entry module", m);
final MediaContent[] mcs = m.getMediaContents();
@ -101,15 +126,14 @@ public class MediaModuleTest extends AbstractTestCase {
assertEquals("http://www.foo.com/path/containing+spaces/trailer.mov", mc.getReference().toString());
}
/**
* @param file to parse
* @return SyndFeed implementation
* @throws IllegalArgumentException
* @throws IOException if file not found or not accessible
* @throws FeedException if parsing failed
*/
private SyndFeed getSyndFeed(final File file) throws IOException, FeedException {
final SyndFeedInput input = new SyndFeedInput();
return input.build(file);
return new SyndFeedInput().build(file);
}
private SyndFeed getSyndFeed(final String filePath) throws IOException, FeedException {
final String fullPath = getTestFile(filePath);
final File file = new File(fullPath);
return new SyndFeedInput().build(file);
}
}

8
src/test/resources/org/rometools/feed/module/mediarss/issue-07.xml Normal file
View file

@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<rss version="2.0" xmlns:media="http://search.yahoo.com/mrss/">
<channel>
<item>
<media:thumbnail url="http://someUrl" height="" width="" />
</item>
</channel>
</rss>