PatchesAndForks/rome
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Do not set unsupported XML parser features

Browse source 
Fixes bug introduced in 2bc58a0. The call to `XMLReader::setFeature`
is used to check if the feature is supported and must happen before
`SAXBuilder::setFeature`. Otherwise XML parsing throws an exception.

The change is not tested, because it is exceptionally cumbersome to
test unsupported features. Possible ways to do it include using an
existing XML library that is known to not support features that the
code is trying to set, or implementing a mock XML parser that doesn't
support any features at all. It's hard to include an XML library
without interfering with other tests and it's hard to implement a mock
XML parser.

Fixes #294
This commit is contained in:
mishako 2016-04-24 20:39:43 +02:00
parent 94861b0532
commit 6920ff0fbe
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
rome/src/main/java/com/rometools/rome/io/WireFeedInput.java
View file

@ -359,7 +359,7 @@ public class WireFeedInput {
} }
} catch (final JDOMException e) { } catch (final JDOMException e) {
throw new IllegalStateException("JDOM could not create a SAX parser"); throw new IllegalStateException("JDOM could not create a SAX parser", e);
} }
saxBuilder.setExpandEntities(false); saxBuilder.setExpandEntities(false);
@ -369,13 +369,19 @@ public class WireFeedInput {
} }
private void setFeature(SAXBuilder saxBuilder, XMLReader parser, String feature, boolean value) { private void setFeature(SAXBuilder saxBuilder, XMLReader parser, String feature, boolean value) {
try { if (isFeatureSupported(parser, feature, value)) {
saxBuilder.setFeature(feature, value); saxBuilder.setFeature(feature, value);
}
}
private boolean isFeatureSupported(XMLReader parser, String feature, boolean value) {
try {
parser.setFeature(feature, value); parser.setFeature(feature, value);
return true;
} catch (final SAXNotRecognizedException e) { } catch (final SAXNotRecognizedException e) {
// ignore return false;
} catch (final SAXNotSupportedException e) { } catch (final SAXNotSupportedException e) {
// ignore return false;
} }
} }