From 62af757574143e92b2b15976559aabc463b53fd1 Mon Sep 17 00:00:00 2001 From: Martin Kurz Date: Sun, 20 Apr 2014 20:53:39 +0200 Subject: [PATCH] just some source cleanup --- .../yahooweather/YWeatherEntryModule.java | 8 +++---- .../yahooweather/YWeatherFeedModule.java | 22 +++++++++---------- .../module/yahooweather/YWeatherModule.java | 6 ++--- .../yahooweather/YWeatherModuleImpl.java | 7 +++++- 4 files changed, 24 insertions(+), 19 deletions(-) diff --git a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherEntryModule.java b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherEntryModule.java index 96f796d..0abeeb4 100644 --- a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherEntryModule.java +++ b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherEntryModule.java @@ -51,26 +51,26 @@ public interface YWeatherEntryModule extends YWeatherModule { * * @return The current conditions. */ - public Condition getCondition(); + Condition getCondition(); /** * The current conditions. * * @param condition The current conditions. */ - public void setCondition(Condition condition); + void setCondition(Condition condition); /** * Forecasts for this location. * * @return Forecasts for this location. */ - public Forecast[] getForecasts(); + Forecast[] getForecasts(); /** * Forecasts for this location. * * @param forecasts Forecasts for this location. */ - public void setForecasts(Forecast[] forecasts); + void setForecasts(Forecast[] forecasts); } diff --git a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherFeedModule.java b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherFeedModule.java index c630dfe..f6f711a 100644 --- a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherFeedModule.java +++ b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherFeedModule.java @@ -53,68 +53,68 @@ public interface YWeatherFeedModule extends YWeatherModule { * * @return The location the feed is for. */ - public Location getLocation(); + Location getLocation(); /** * The location the feed is for. * * @param location The location the feed is for. */ - public void setLocation(Location location); + void setLocation(Location location); /** * Astronomical information for the location. * * @return Astronomical information for the location. */ - public Astronomy getAstronomy(); + Astronomy getAstronomy(); /** * Astronomical information for the location. * * @param astronomy Astronomical information for the location. */ - public void setAstronomy(Astronomy astronomy); + void setAstronomy(Astronomy astronomy); /** * Units that data in the feed is provided in. * * @return Units that data in the feed is provided in. */ - public Units getUnits(); + Units getUnits(); /** * Units that data in the feed is provided in. * * @param units Units that data in the feed is provided in. */ - public void setUnits(Units units); + void setUnits(Units units); /** * Current wind conditions at the location. * * @return Current wind conditions at the location. */ - public Wind getWind(); + Wind getWind(); /** * Current wind conditions at the location. * * @param wind Current wind conditions at the location. */ - public void setWind(Wind wind); + void setWind(Wind wind); /** * The current atmospheric conditions. * * @return Atmosphere object. */ - public Atmosphere getAtmosphere(); + Atmosphere getAtmosphere(); /** - * Sets the current atmopheric condictions + * Sets the current atmopheric condictions. * * @param value Atmosphere object. */ - public void setAtmosphere(Atmosphere value); + void setAtmosphere(Atmosphere value); } diff --git a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModule.java b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModule.java index b885dd5..244b1d9 100644 --- a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModule.java +++ b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModule.java @@ -38,14 +38,14 @@ package org.rometools.feed.module.yahooweather; import com.sun.syndication.feed.module.Module; /** - * A simple parent interface that defines the feed URI + * A simple parent interface that defines the feed URI. * * @version $Id: YWeatherModule.java,v 1.2 2008/01/22 14:50:06 kebernet Exp $ * @author Robert "kebernet" Cooper */ public interface YWeatherModule extends Module { /** - * "http://xml.weather.yahoo.com/ns/rss/1.0" + * "http://xml.weather.yahoo.com/ns/rss/1.0". */ - public static String URI = "http://xml.weather.yahoo.com/ns/rss/1.0"; + String URI = "http://xml.weather.yahoo.com/ns/rss/1.0"; } diff --git a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModuleImpl.java b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModuleImpl.java index 00156ad..ba39ac8 100644 --- a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModuleImpl.java +++ b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModuleImpl.java @@ -63,6 +63,8 @@ public class YWeatherModuleImpl extends ModuleImpl implements YWeatherEntryModul private Wind wind; private Forecast[] forecasts; + /** + */ public YWeatherModuleImpl() { super(YWeatherModuleImpl.class, YWeatherModule.URI); } @@ -164,6 +166,9 @@ public class YWeatherModuleImpl extends ModuleImpl implements YWeatherEntryModul this.atmosphere = atmosphere; } - public static interface CopyFromInterface extends YWeatherFeedModule, YWeatherEntryModule { + /** + * Inteface combining feed and entry module. + */ + public interface CopyFromInterface extends YWeatherFeedModule, YWeatherEntryModule { } }