();
nss.add(SSEModule.SSE_NS);
NAMESPACES = Collections.unmodifiableSet(nss);
}
@@ -33,7 +35,7 @@ public abstract class SSEModule implements Module {
}
@Override
- public Class getInterface() {
+ public Class extends Module> getInterface() {
return getClass();
}
@@ -54,5 +56,5 @@ public abstract class SSEModule implements Module {
}
@Override
- public abstract void copyFrom(CopyFrom obj);
+ public abstract void copyFrom(CopyFrom extends Module> obj);
}
diff --git a/src/main/java/org/rometools/feed/module/sse/modules/Sharing.java b/src/main/java/org/rometools/feed/module/sse/modules/Sharing.java
index bbdb415..265e79c 100644
--- a/src/main/java/org/rometools/feed/module/sse/modules/Sharing.java
+++ b/src/main/java/org/rometools/feed/module/sse/modules/Sharing.java
@@ -3,6 +3,7 @@ package org.rometools.feed.module.sse.modules;
import java.util.Date;
import com.sun.syndication.feed.CopyFrom;
+import com.sun.syndication.feed.module.Module;
/**
*
@@ -24,6 +25,8 @@ import com.sun.syndication.feed.CopyFrom;
* .
*/
public class Sharing extends SSEModule {
+ private static final long serialVersionUID = 8626705992778126861L;
+
public static final String NAME = "sharing";
public static final String UNTIL_ATTRIBUTE = "until";
@@ -49,7 +52,7 @@ public class Sharing extends SSEModule {
private Related related;
@Override
- public void copyFrom(final CopyFrom obj) {
+ public void copyFrom(final CopyFrom extends Module> obj) {
final Sharing sharing = (Sharing) obj;
ordered = sharing.ordered;
since = sharing.since == null ? null : (Date) sharing.since.clone();
diff --git a/src/main/java/org/rometools/feed/module/sse/modules/Sync.java b/src/main/java/org/rometools/feed/module/sse/modules/Sync.java
index c7ccb4e..7a65894 100644
--- a/src/main/java/org/rometools/feed/module/sse/modules/Sync.java
+++ b/src/main/java/org/rometools/feed/module/sse/modules/Sync.java
@@ -4,6 +4,7 @@ import java.util.ArrayList;
import java.util.List;
import com.sun.syndication.feed.CopyFrom;
+import com.sun.syndication.feed.module.Module;
/**
*
@@ -25,6 +26,8 @@ import com.sun.syndication.feed.CopyFrom;
* .
*/
public class Sync extends SSEModule {
+ private static final long serialVersionUID = 3071686432594143174L;
+
public static final String NAME = "sync";
public static final String ID_ATTRIBUTE = "id";
@@ -42,10 +45,10 @@ public class Sync extends SSEModule {
private Boolean conflict;
private History history;
- private List conflicts;
+ private List conflicts;
@Override
- public void copyFrom(final CopyFrom obj) {
+ public void copyFrom(final CopyFrom extends Module> obj) {
final Sync sync = (Sync) obj;
deleted = sync.deleted;
version = sync.version;
@@ -53,7 +56,7 @@ public class Sync extends SSEModule {
id = sync.id;
history = sync.history == null ? null : (History) sync.history.clone();
if (sync.conflicts != null) {
- conflicts = new ArrayList();
+ conflicts = new ArrayList();
conflicts.addAll(sync.conflicts);
}
}
@@ -155,16 +158,16 @@ public class Sync extends SSEModule {
public void addConflict(final Conflict conflict) {
if (conflicts == null) {
- conflicts = new ArrayList();
+ conflicts = new ArrayList();
}
conflicts.add(conflict);
}
- public List getConflicts() {
+ public List getConflicts() {
return conflicts;
}
- public void setConflicts(final List conflicts) {
+ public void setConflicts(final List conflicts) {
this.conflicts = conflicts;
}
}
diff --git a/src/main/java/org/rometools/feed/module/sse/modules/Update.java b/src/main/java/org/rometools/feed/module/sse/modules/Update.java
index f9db47c..0f05239 100644
--- a/src/main/java/org/rometools/feed/module/sse/modules/Update.java
+++ b/src/main/java/org/rometools/feed/module/sse/modules/Update.java
@@ -3,6 +3,7 @@ package org.rometools.feed.module.sse.modules;
import java.util.Date;
import com.sun.syndication.feed.CopyFrom;
+import com.sun.syndication.feed.module.Module;
/**
*
@@ -18,6 +19,7 @@ import com.sun.syndication.feed.CopyFrom;
* .
*/
public class Update extends SSEModule {
+ private static final long serialVersionUID = 4806771926023433667L;
public static final String NAME = "update";
public static final String BY_ATTRIBUTE = "by";
public static final String WHEN_ATTRIBUTE = "when";
@@ -26,7 +28,7 @@ public class Update extends SSEModule {
private String by;
@Override
- public void copyFrom(final CopyFrom other) {
+ public void copyFrom(final CopyFrom extends Module> other) {
final Update otherUpdate = (Update) other;
otherUpdate.when = when == null ? null : (Date) when.clone();
// dont copy immutable
diff --git a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModuleImpl.java b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModuleImpl.java
index ede9f9e..893c043 100644
--- a/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModuleImpl.java
+++ b/src/main/java/org/rometools/feed/module/yahooweather/YWeatherModuleImpl.java
@@ -44,6 +44,7 @@ import org.rometools.feed.module.yahooweather.types.Units;
import org.rometools.feed.module.yahooweather.types.Wind;
import com.sun.syndication.feed.CopyFrom;
+import com.sun.syndication.feed.module.Module;
import com.sun.syndication.feed.module.ModuleImpl;
/**
@@ -53,6 +54,7 @@ import com.sun.syndication.feed.module.ModuleImpl;
* @author Robert "kebernet" Cooper
*/
public class YWeatherModuleImpl extends ModuleImpl implements YWeatherEntryModule, YWeatherFeedModule {
+ private static final long serialVersionUID = -4753704339578661020L;
private Location location;
private Astronomy astronomy;
private Atmosphere atmosphere;
@@ -66,12 +68,12 @@ public class YWeatherModuleImpl extends ModuleImpl implements YWeatherEntryModul
}
@Override
- public Class getInterface() {
+ public Class extends Module> getInterface() {
return CopyFromInterface.class;
}
@Override
- public void copyFrom(final CopyFrom o) {
+ public void copyFrom(final CopyFrom extends Module> o) {
final YWeatherModuleImpl from = (YWeatherModuleImpl) o;
setAstronomy(from.getAstronomy() != null ? (Astronomy) from.getAstronomy().clone() : null);
setCondition(from.getCondition() != null ? (Condition) from.getCondition().clone() : null);
diff --git a/src/main/java/org/rometools/feed/module/yahooweather/io/WeatherModuleGenerator.java b/src/main/java/org/rometools/feed/module/yahooweather/io/WeatherModuleGenerator.java
index 3fa48d2..c8a5d30 100644
--- a/src/main/java/org/rometools/feed/module/yahooweather/io/WeatherModuleGenerator.java
+++ b/src/main/java/org/rometools/feed/module/yahooweather/io/WeatherModuleGenerator.java
@@ -39,6 +39,7 @@ package org.rometools.feed.module.yahooweather.io;
import java.text.SimpleDateFormat;
import java.util.HashSet;
+import java.util.Set;
import org.jdom2.Element;
import org.jdom2.Namespace;
@@ -203,10 +204,9 @@ public class WeatherModuleGenerator implements ModuleGenerator {
}
@Override
- public java.util.Set getNamespaces() {
- final HashSet set = new HashSet();
+ public Set getNamespaces() {
+ final Set set = new HashSet();
set.add(WeatherModuleGenerator.NS);
-
return set;
}
diff --git a/src/main/java/org/rometools/feed/module/yahooweather/io/WeatherModuleParser.java b/src/main/java/org/rometools/feed/module/yahooweather/io/WeatherModuleParser.java
index f82e900..cef27c6 100644
--- a/src/main/java/org/rometools/feed/module/yahooweather/io/WeatherModuleParser.java
+++ b/src/main/java/org/rometools/feed/module/yahooweather/io/WeatherModuleParser.java
@@ -42,6 +42,7 @@ import java.text.ParseException;
import java.text.SimpleDateFormat;
import java.util.Iterator;
import java.util.List;
+import java.util.Locale;
import java.util.logging.Logger;
import org.jdom2.Element;
@@ -83,7 +84,7 @@ public class WeatherModuleParser implements ModuleParser {
}
@Override
- public Module parse(final Element element) {
+ public Module parse(final Element element, final Locale locale) {
final YWeatherModuleImpl module = new YWeatherModuleImpl();
final Element location = element.getChild("location", WeatherModuleParser.NS);
@@ -152,14 +153,14 @@ public class WeatherModuleParser implements ModuleParser {
}
}
- final List forecasts = element.getChildren("forecast", WeatherModuleParser.NS);
+ final List forecasts = element.getChildren("forecast", WeatherModuleParser.NS);
if (forecasts != null) {
final Forecast[] f = new Forecast[forecasts.size()];
int i = 0;
- for (final Iterator it = forecasts.iterator(); it.hasNext(); i++) {
- final Element forecast = (Element) it.next();
+ for (final Iterator it = forecasts.iterator(); it.hasNext(); i++) {
+ final Element forecast = it.next();
try {
f[i] = new Forecast(forecast.getAttributeValue("day"), SHORT_DATE.parse(forecast.getAttributeValue("date")), Integer.parseInt(forecast
diff --git a/src/test/java/org/rometools/feed/module/sse/SSEParserTest.java b/src/test/java/org/rometools/feed/module/sse/SSEParserTest.java
index cd0bb9e..9c7c677 100644
--- a/src/test/java/org/rometools/feed/module/sse/SSEParserTest.java
+++ b/src/test/java/org/rometools/feed/module/sse/SSEParserTest.java
@@ -12,6 +12,7 @@ import java.util.ArrayList;
import java.util.Date;
import java.util.Iterator;
import java.util.List;
+import java.util.Locale;
import junit.framework.Test;
import junit.framework.TestSuite;
@@ -153,8 +154,8 @@ public class SSEParserTest extends AbstractTestCase {
// this test is brittle, but its comprehensive
if ("until".equals(a1Name) || "since".equals(a1Name) || "when".equals(a1Name)) {
- av1 = DateParser.parseRFC822((String) av1);
- av2 = DateParser.parseRFC822((String) av2);
+ av1 = DateParser.parseRFC822((String) av1, Locale.US);
+ av2 = DateParser.parseRFC822((String) av2, Locale.US);
}
assertTrue("unequal attributes:" + one.getName() + "." + a1.getName() + ": " + av1 + " != " + av2, av1.equals(av2));
@@ -247,7 +248,7 @@ public class SSEParserTest extends AbstractTestCase {
final Date when = history.getWhen();
assertNotNull(when);
- final Date testDate = DateParser.parseRFC822("Fri, 6 Jan 2006 19:24:09 GMT");
+ final Date testDate = DateParser.parseRFC822("Fri, 6 Jan 2006 19:24:09 GMT", Locale.US);
assertEquals(testDate, when);
}