handle content:// uri scheme properly too, close #28

app/src/main/java/com/simplemobiletools/gallery/MyViewPager.java

@@ -1,7 +1,6 @@
 package com.simplemobiletools.gallery;
 
 import android.content.Context;
-import android.support.v4.view.ViewPager;
 import android.util.AttributeSet;
 import android.view.MotionEvent;
 

app/src/main/kotlin/com/simplemobiletools/gallery/activities/EditActivity.kt

@@ -5,6 +5,7 @@ import android.graphics.Bitmap
 import android.media.MediaScannerConnection
 import android.net.Uri
 import android.os.Bundle
+import android.provider.MediaStore
 import android.util.Log
 import android.view.Menu
 import android.view.MenuItem
@@ -66,12 +67,30 @@ class EditActivity : SimpleActivity(), CropImageView.OnCropImageCompleteListener
     override fun onCropImageComplete(view: CropImageView, result: CropImageView.CropResult) {
         if (result.error == null) {
             if (uri.scheme == "file") {
-                val path = uri.path
+                saveBitmapToFile(result.bitmap, uri.path)
+            } else if (uri.scheme == "content") {
+                saveBitmapToFile(result.bitmap, convertMediaUriToPath(uri))
+            } else {
+                toast(R.string.unknown_file_location)
+                finish()
+            }
+        } else {
+            toast("${getString(R.string.image_croping_failed)} ${result.error.message}")
+        }
+    }
+
+    private fun saveBitmapToFile(bitmap: Bitmap, path: String) {
         val file = File(path)
+        if (!file.exists()) {
+            toast(R.string.error_saving_file)
+            finish()
+            return
+        }
+
         var out: FileOutputStream? = null
         try {
             out = FileOutputStream(file)
-                    result.bitmap.compress(getCompressionFormat(file), 100, out)
+            bitmap.compress(getCompressionFormat(file), 100, out)
             setResult(Activity.RESULT_OK, intent)
         } catch (e: Exception) {
             Log.e(TAG, "Crop compressing failed $e")
@@ -89,15 +108,6 @@ class EditActivity : SimpleActivity(), CropImageView.OnCropImageCompleteListener
             setResult(Activity.RESULT_OK, intent)
             finish()
         })
-            } else if (uri.scheme == "content") {
-
-            } else {
-                toast(R.string.unknown_file_location)
-                finish()
-            }
-        } else {
-            toast("${getString(R.string.image_croping_failed)} ${result.error.message}")
-        }
     }
 
     private fun getCompressionFormat(file: File): Bitmap.CompressFormat {
@@ -107,4 +117,14 @@ class EditActivity : SimpleActivity(), CropImageView.OnCropImageCompleteListener
             else -> Bitmap.CompressFormat.JPEG
         }
     }
+
+    private fun convertMediaUriToPath(uri: Uri): String {
+        val proj = arrayOf(MediaStore.Images.Media.DATA)
+        val cursor = contentResolver.query(uri, proj, null, null, null)
+        val index = cursor.getColumnIndexOrThrow(MediaStore.Images.Media.DATA)
+        cursor.moveToFirst()
+        val path = cursor.getString(index)
+        cursor.close()
+        return path
+    }
 }

app/src/main/res/values-de/strings.xml

@@ -53,6 +53,7 @@
     <string name="edit_image_with">Edit image with:</string>
     <string name="no_editor_found">No image editor found</string>
     <string name="unknown_file_location">Unknown file location</string>
+    <string name="error_saving_file">Could not overwrite the source file</string>
 
     <!-- About -->
     <string name="about">Über</string>

app/src/main/res/values-es/strings.xml

@@ -53,6 +53,7 @@
     <string name="edit_image_with">Edit image with:</string>
     <string name="no_editor_found">No image editor found</string>
     <string name="unknown_file_location">Unknown file location</string>
+    <string name="error_saving_file">Could not overwrite the source file</string>
 
     <!-- About -->
     <string name="about">Acerca de</string>

app/src/main/res/values-it/strings.xml

@@ -53,6 +53,7 @@
     <string name="edit_image_with">Edit image with:</string>
     <string name="no_editor_found">No image editor found</string>
     <string name="unknown_file_location">Unknown file location</string>
+    <string name="error_saving_file">Could not overwrite the source file</string>
 
     <!-- About -->
     <string name="about">Informazioni</string>

app/src/main/res/values-ja/strings.xml

@@ -53,6 +53,7 @@
     <string name="edit_image_with">Edit image with:</string>
     <string name="no_editor_found">No image editor found</string>
     <string name="unknown_file_location">Unknown file location</string>
+    <string name="error_saving_file">Could not overwrite the source file</string>
 
     <!-- About -->
     <string name="about">アプリについて</string>

app/src/main/res/values-pt-rPT/strings.xml

@@ -53,6 +53,7 @@
     <string name="edit_image_with">Edit image with:</string>
     <string name="no_editor_found">No image editor found</string>
     <string name="unknown_file_location">Unknown file location</string>
+    <string name="error_saving_file">Could not overwrite the source file</string>
 
     <!-- About -->
     <string name="about">Sobre</string>

app/src/main/res/values-sv/strings.xml

@@ -53,6 +53,7 @@
     <string name="edit_image_with">Edit image with:</string>
     <string name="no_editor_found">No image editor found</string>
     <string name="unknown_file_location">Unknown file location</string>
+    <string name="error_saving_file">Could not overwrite the source file</string>
 
     <!-- About -->
     <string name="about">Om</string>

app/src/main/res/values/strings.xml

@@ -53,6 +53,7 @@
     <string name="edit_image_with">Edit image with:</string>
     <string name="no_editor_found">No image editor found</string>
     <string name="unknown_file_location">Unknown file location</string>
+    <string name="error_saving_file">Could not overwrite the source file</string>
 
     <!-- About -->
     <string name="about">About</string>