2
0
Fork 0
mirror of https://github.com/ch11ng/exwm.git synced 2025-04-17 08:34:03 +02:00

Fix EXWM buffers not being hidden on workspace switch

When I switch workspaces, EXWM buffers are not correctly hidden, but stays visible and in the way of the buffers I actually want to use. I tracked it down to the `output-{new,old}` objects being equal component wise, but not reference wise in this `cond` clause. Using the less-strict component-wise equality test of `equal` fixed it for me.

I see there are many uses of `eq` in the EXWM source in general. Maybe there are more bugs in here due to the use of too-strict equality tests with `eq`. Just a thing to consider.
This commit is contained in:
Johan Johansson 2018-02-28 10:45:59 +01:00 committed by GitHub
parent ad90af19a6
commit 65f8921671
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -536,7 +536,7 @@ for internal use only."
(cond
((not active-old)
(exwm-workspace--set-active frame t))
((eq output-old output-new)
((equal output-old output-new)
(exwm-workspace--set-active old-frame nil)
(exwm-workspace--set-active frame t)
(setq workspaces-to-hide (list old-frame)))