Commit graph

3120 commits

Author SHA1 Message Date
Naveen
46533e4b45 Minor code improvements 2022-06-18 14:35:04 +05:30
tibbi
0b3c900a02 fix a glitch after rotating the device with screen off 2022-06-17 22:54:11 +02:00
tibbi
dc53582a51 add a backup dialog for redirecting to media management settings 2022-06-17 09:40:58 +02:00
tibbi
8bfa7fdc7c use the new way of getting FileDirItem content URIs 2022-06-15 16:29:45 +02:00
tibbi
ff5019998d pass the MediaStoreId with FileDirItems at deleting too 2022-06-15 12:20:53 +02:00
tibbi
87b4bdc6b3 updating commons 2022-06-15 12:02:39 +02:00
tibbi
4b7c86f000 make the media placeholder clickable too 2022-06-12 21:52:50 +02:00
Naveen
a2b70485fa Bring placeholder text view to front 2022-06-12 16:10:30 +05:30
tibbi
f297cc6d2e add the temporary excluded folder showing in Whats New 2022-06-06 16:46:08 +02:00
tibbi
0e0a3e5596 lets show Temporarily show excluded, even if empty 2022-06-06 16:42:11 +02:00
tibbi
45844439dd catch and show exceptions thrown at cropping third party intents 2022-06-05 22:55:04 +02:00
tibbi
550f42f110 show "Temporarily show excluded" only if we have any excluded folders 2022-06-05 11:52:04 +02:00
tibbi
d28d57f961 allow protecting excluded folder visibility 2022-06-05 11:37:20 +02:00
tibbi
284ff32771 add a button for temporarily showing excluded 2022-06-05 11:27:06 +02:00
tibbi
b45f682e72 make sure we show the proper video at opening from Favorites 2022-05-31 11:19:41 +02:00
tibbi
8c47d9e5ba fixing a glitch with missing thumbnails at random sorting 2022-05-31 09:51:34 +02:00
tibbi
2838887c83 fix a glitch with wrong sorting by date taken 2022-05-31 09:17:08 +02:00
tibbi
4ab9fcb29d show the media managemement prompt at every app launch, if needed 2022-05-30 22:52:00 +02:00
darthpaul
6fbdb8aa51 excluded folders should not enforce storage restrictions on SDK 30+ 2022-05-26 10:30:54 +01:00
tibbi
fda1b5eeba removing some redundant refreshing 2022-05-25 09:48:47 +02:00
Tibor Kaputa
79b3870598
Merge pull request #2483 from KryptKode/fix/move_position
fix: position returning to 0 after moving file
2022-05-25 09:39:16 +02:00
darthpaul
c33443ed4e fix: position returning to 0 after moving file 2022-05-24 23:42:14 +01:00
Tibor Kaputa
32a20df49b
Merge pull request #2471 from DoozyDoz/feat_size_at_deletion
[feat] Display item(s) size in delete dialog
2022-05-23 22:09:13 +02:00
Tibor Kaputa
4ac8c42e9c
adding a newline 2022-05-23 22:08:42 +02:00
Doozy
1349d4c6e0 [Removed] showing item size for folder deletion 2022-05-23 11:24:41 +03:00
tibbi
335f3f5fc5 do not update file last modified after a file operation, if it is zero 2022-05-21 16:59:16 +02:00
tibbi
50d022c31d allow creating new folders from the main screen too again 2022-05-20 22:50:23 +02:00
Tibor Kaputa
734ee5c6d8
Merge pull request #2473 from KryptKode/fix/delete_position_in_view_pager
fix: position returning to 0
2022-05-20 11:34:02 +02:00
darthpaul
ec6e532c52 fix: position returning to 0
- call onPageSelected(0) if the media.size == 1
2022-05-20 00:02:33 +01:00
Doozy
33c1ddd761 Changes for readability 2022-05-19 11:26:09 +03:00
Doozy
6080191e1a Changed back to File extension 2022-05-19 10:58:37 +03:00
Doozy
914d97c231 Changes for readability 2022-05-19 10:55:26 +03:00
Doozy
fb17549173 Code cleanup (post review) 2022-05-19 10:39:57 +03:00
Doozy
a368db9b87 [feat] Display item(s) size in delete dialog 2022-05-18 18:27:27 +03:00
Tibor Kaputa
bbb806a5e6
Merge pull request #2469 from KryptKode/fix/delete_position_in_view_pager
fix: position returning to 0
2022-05-16 21:29:55 +02:00
darthpaul
dad1a6e817 fix: position returning to 0
- for calling  refreshUI(media, true) would refresh the view pager position, cause mPos to be set back to 0,
so we retain the original behaviour and call refreshUI(media, false)
- when items have been removed up until the last item in the adapter, the ViewPager's OnPageChangeListener.onPageSelected does not get called for the first item
so mPos is never set to zero and deletion fails.
- we add a call in OnPageChangeListener.onPageScrolled to call onPageSelected(0), when the position == 0 to fix this.
2022-05-16 18:44:23 +01:00
tibbi
9addf4b235 adding some widget UI related improvements 2022-05-14 22:30:06 +02:00
tibbi
290a84f699 accept Media access in foss variant too, do not require All files 2022-05-14 20:03:23 +02:00
tibbi
4936eecb17 require the All Files access in foss and prepaid app variants 2022-05-14 15:15:43 +02:00
Tibor Kaputa
2e4d605940
Merge pull request #2464 from KryptKode/fix/android_12_mediastore_crash
fix media store crash on deletion on android 12
2022-05-14 12:27:23 +02:00
darthpaul
3571fcd3ab fix media store crash on deletion on android 12
- MediaStore crashed on deletion because the ViewPagerActivity got finish before the MediaStore.createDeleteRequest executes
- To fix, we apply the same approach in the MediaActivity and finish explicitly after deletion completes, if the media list is empty
- also, only refresh the UI when the media list is not empty to avoid UI glitches
- fix slideshow bug by resetting mAreSlideShowMediaVisible back to false when the slideshow ends
2022-05-14 03:51:52 +01:00
tibbi
50f6bb5871 add floating contextual menu at some setting screens 2022-05-09 22:18:21 +02:00
tibbi
7fc6767e4c adding some widget config related improvements 2022-05-09 11:20:12 +02:00
tibbi
45a8ee0ec0 do not show the Media Management prompt with All files permission 2022-05-09 10:46:43 +02:00
tibbi
c5d9ac6fcc prepare the app for having All files permission 2022-05-09 10:44:50 +02:00
tibbi
969f0334f3 check noMedia file existence only below Android 11 in some cases 2022-05-08 09:33:56 +02:00
tibbi
0b2f0da4be fix third party intent handling when folder is hidden with a dot 2022-05-07 22:16:27 +02:00
tibbi
048b109f8a adding a crashfix and updating commons 2022-05-04 12:30:15 +02:00
tibbi
146a1b1d69 adding a Prepaid product flavor 2022-05-03 10:56:16 +02:00
tibbi
45cf8da60f catch exceptions thrown at getDeletedMediaCount() 2022-05-03 10:44:40 +02:00
tibbi
f3eb312e57 fix #1113, #2309, fixing some wallpaper setting related glitches 2022-05-03 10:38:36 +02:00
tibbi
b2130669ab use "Fix Date Taken values" on Android 11+ file fetching 2022-05-03 10:14:18 +02:00
darthpaul
b4262111d7 use MediaStore request way of deleting files on SDK 31
- on SDK 31+, if the app can manange media, we want to use the MediaStore request way of deleting files
- we use the new method added BaseSimpleActivity.checkManageMediaOrHandleSAFDialogSdk30 that performs the check and determines if we should show the SAF dialog or not
2022-04-30 23:58:21 +01:00
darthpaul
aca71be5d8 handle mange media for renaming
- move the launchMediaManagementIntent method to commons module
2022-04-28 01:09:11 +01:00
tibbi
1d25512053 adding some widget config related improvements 2022-04-25 22:44:58 +02:00
tibbi
0679b22887 show the Media Management prompt on Android 12+ from time to time 2022-04-24 16:55:40 +02:00
tibbi
91a71685bd show the media management prompt at copy/move/delete too 2022-04-24 16:21:00 +02:00
tibbi
6428836c73 add a prompt for making the app the default media management app 2022-04-24 16:11:51 +02:00
tibbi
893690d569 show a nicer error message at copying to an invalid folder 2022-04-20 11:42:43 +02:00
tibbi
09bea7d508 fix #2309, allow setting both portrait and landscape wallpapers 2022-04-20 10:42:12 +02:00
tibbi
a9d5604843 fix third party intent handling if selected folder contains .nomedia 2022-04-19 19:35:59 +02:00
tibbi
a73bf966b4 adding a crashfix 2022-04-16 15:07:23 +02:00
darthpaul
5e4550d52b fix: restore to android folder on SDK30 2022-04-16 11:44:22 +01:00
tibbi
c82a683302 do not always check write permissions at FilePickerDialog 2022-04-16 12:15:44 +02:00
darthpaul
bc5f0ce175 handle picking restricted folders in PickDirectoryDialog
- users should not be able to pick restricted folders in PickDirectoryDialog when copying/moving files on SDK 30+
- show nice error message R.string.system_folder_restriction when user picks a restricted folder on SDK 30+
- restricted folders on SDK 30+ are: Android, Root of Internal and SDCard. The Download directory is writable
2022-04-16 10:12:34 +01:00
tibbi
7a24f6f05b lets show the disabled hidden item displaying in Whats New 2022-04-15 21:30:33 +02:00
tibbi
5d5c9e1920 request MEDIA_LOCATION on SDK 30 already 2022-04-15 09:03:32 +02:00
darthpaul
86dce4e48d request ACCESS_MEDIA_LOCATION permission
- the app has declared the MANAGE_MEDIA permission in the AndroidManifest
- also requesting the ACCESS_MEDIA_LOCATION permission will make the system not to show the user the prompts from MediaStore.createWriteRequest and MediaStore.createDeleteRequest
2022-04-14 22:59:57 +01:00
darthpaul
b2d08c401e restore from recycle bin SDK 30+
- when file is on the root of Internal Storage or SD Card, change the destination to the /Pictures folder, we cannot write to the root of any volume on SDK 30+
- call handleSAFDialogSdk30, so users are prompted to allow SAF when restoring, if not previously allowed
- if there are conflicts, handle it as though it's a CONFLICT_KEEP_BOTH by appending some characters to the destination name
- add new string restore_to_path shown when restoring to /Pictures folder on SDK 30+ instead of the root folder
2022-04-11 16:23:14 +01:00
tibbi
f69ba7fb32 avoid showing a progress toast twice at fixing date taken value 2022-04-10 20:23:27 +02:00
tibbi
3e426148dd show edit and set_as menu buttons only if 1 item is selected 2022-04-10 20:14:42 +02:00
tibbi
36beff5214 updating commons 2022-04-10 20:10:19 +02:00
tibbi
96fb6a0e35 updating the photo editor, use light theme when appropriate 2022-04-10 17:52:37 +02:00
tibbi
83881bfc06 make sure we use proper colors at PhotoVideoActivity too 2022-04-10 16:47:30 +02:00
tibbi
417a84f21a use proper menu colors at fullscreen view 2022-04-10 16:28:27 +02:00
tibbi
17610252c0 make sure we always use white system icons at fullscreen view 2022-04-10 16:21:32 +02:00
tibbi
39c568777b updating a string 2022-04-10 12:15:17 +02:00
darthpaul
519353cb04 change toast duration
- change the toast duration for when a user picks a folder restricted on SDK 30+ to Toast.LENGTH_LONG
2022-04-10 10:57:35 +01:00
darthpaul
fe49035966 Merge remote-tracking branch 'origin/fix/rename_by_changing_case' into fix/rename_by_changing_case 2022-04-10 10:56:11 +01:00
darthpaul
cebc9cdfda change toast duration
- change the toast duration for when a user cannot renamed files in the root of the SD Card to Toast.LENGTH_LONG
2022-04-10 10:55:49 +01:00
Paul
bfd4b930ec
Merge branch 'master' into fix/rename_by_changing_case 2022-04-10 10:49:10 +01:00
darthpaul
e1d8f601d7 fix renaming
- show error message when a user tries to rename a file on the root of the SD Card in ViewPagerActivity and MediaAdapter
- in PickDirectoryDialog, use the Activity.isAStorageRootFolder method instead of String.isBasePath
2022-04-10 09:56:21 +01:00
Paul
0e6b935fc5
Merge branch 'master' into fix/editor-sdk30+ 2022-04-09 23:42:17 +01:00
darthpaul
8da45dcfbb sdk 30+ changes
- handle WRITE_STORAGE permission in EditActivity
- in PickDirectoryDialog replace error message when users select a restricted system directory to R.string.system_folder_restriction
- in SaveDialog
    - if path is a restricted path, automatically change it to {CURRENT_VOLUME}/Pictures directory.
    - if there is conflict and the file is direct child of the Download folder, show the user a prompt to grant WRITE request permission
- remove unused string R.string.copy_to_restricted_folder_message
- in NewPhotoEditActivity and NewVideoEditActivity, only delete SD Card file on conflict for devices running lower than SDK 30
- update commons module
2022-04-09 23:34:52 +01:00
tibbi
2ea542b461 force white menu items at viewpager activity 2022-04-04 23:20:29 +02:00
tibbi
7eac78411e adding some preparation for Material You theme 2022-04-04 15:58:05 +02:00
tibbi
75f8592940 adding a couple more Android 12 related fixes 2022-04-04 15:32:08 +02:00
darthpaul
52693adbe6 Update gallery with recent commons module 2022-03-31 04:46:09 +01:00
tibbi
0a03658978 do not show root folder at storage picker dialog 2022-03-23 22:15:09 +01:00
tibbi
7feffc9f61 updating the placeholder text for Android R+ 2022-03-20 20:41:45 +01:00
Tibor Kaputa
0d43373cb4
Merge pull request #2383 from KryptKode/fix/sdk30-saf-source-folder
sdk 30 changes
2022-03-19 22:19:05 +01:00
darthpaul
399c8e241d SDK 30 changes
- handle SAF dialog on ViewPagerActivity before refreshing screen
2022-03-19 20:30:59 +00:00
darthpaul
fa991847fb sdk 30 changes
- remove handleSAFDialogSdk30 for source paths since we have READ permission
2022-03-19 19:49:16 +00:00
tibbi
4a3e502484 moving MySquareImageView into commons 2022-03-18 17:33:44 +01:00
darthpaul
9a3d16354c update commons 2022-03-13 03:37:40 +00:00
darthpaul
fedc56846a SDK 30 changes
- show error when user tries to pick the root directory of any volume
- handle SAF for SDK 30 before copying/moving files
2022-03-13 03:17:42 +00:00
tibbi
360c3529ea refetch viewpager item position if it is -1 too 2022-03-01 12:08:15 +01:00
tibbi
61440e2f22 avoid refetching viewpager position after file deleting 2022-02-28 17:29:17 +01:00
tibbi
16e522cc03 adding a new string related to seeing ads during videos 2022-02-28 17:05:05 +01:00
tibbi
8cb4b9bc3b Merge branch 'ref/delete-animation' of https://github.com/KryptKode/Simple-Gallery 2022-02-25 23:04:24 +01:00
darthpaul
8af61d89bb Revert changes and handle recycler view animation with SDK-30 delete 2022-02-24 16:27:33 +00:00
darthpaul
bbcb41cf1f fix: show delete animation after file delete 2022-02-15 00:21:53 +00:00
tibbi
9529173e0a rescan path from third party intent if not in mediastore 2022-02-14 22:57:19 +01:00
tibbi
318664fca1 fix #2332, try showing an image asap at third party intents 2022-02-14 11:08:49 +01:00
tibbi
080e7e983d clear cached media at launching viewpager at third party intent 2022-02-14 10:48:19 +01:00
tibbi
4e1136df80 updating commons 2022-02-13 20:55:03 +01:00
tibbi
581dd43bd6 fix #1427, properly handle diacritics at sorting 2022-02-13 17:57:30 +01:00
tibbi
f3e76cfb50 fix sorting of folders with Group direct subfolders enabled 2022-02-13 17:02:28 +01:00
tibbi
80390c67f2 refresh items after sorting/filtering/grouping only if something changed 2022-02-13 16:42:21 +01:00
tibbi
5e548e0460 fix #2336, really delete files from the device after 30 days in the bin 2022-02-13 12:08:34 +01:00
tibbi
a1589b60f1 fix opening videos in the recycle bin directly 2022-02-13 11:59:54 +01:00
tibbi
3e3fb0c580 fix a glitch with the inability to display hidden files anymore 2022-02-13 11:02:51 +01:00
tibbi
9577a5e8e2 do not show the Temporarily show/hide hidden at the media screen either 2022-02-12 18:52:24 +01:00
tibbi
144409b7a9 adding more menu visibility changes 2022-02-12 18:12:16 +01:00
tibbi
cfbeb85b0d removing some settings and filepickers on Android 11+ 2022-02-12 18:02:29 +01:00
tibbi
032ca877ed merging General and Visibility setting sections 2022-02-12 17:54:44 +01:00
tibbi
ad9f39cea4 removing the FAQ item about showing specific folders only too 2022-02-12 17:51:36 +01:00
tibbi
fc365c3d36 so ye, lets remove some un/hide related menu items on Android 11+ 2022-02-12 17:48:36 +01:00
tibbi
de1a58e1b9 adding another string related to removing Manage Included Folders 2022-02-12 17:41:37 +01:00
tibbi
c08aa99a2a add some explanation about un/hiding no longer being available anywhere 2022-02-12 16:19:58 +01:00
tibbi
45c5ac9fe8 adding some keyboard hiding 2022-02-12 12:06:29 +01:00
tibbi
f6c6b402c6 properly fetch Favorite file sizes to avoid caching glitches 2021-12-25 21:02:45 +01:00
tibbi
51c15be895 updating commons 2021-12-19 21:25:57 +01:00
tibbi
f6178854ed Merge branch 'master' of github.com:SimpleMobileTools/Simple-Gallery 2021-12-17 15:30:56 +01:00
Tibor Kaputa
040599dd12
Merge pull request #2292 from Aga-C/add-group-count
Added option to show file count in groups (#2281)
2021-12-17 15:30:51 +01:00
tibbi
edb25a6053 Merge branch 'master' of github.com:SimpleMobileTools/Simple-Gallery 2021-12-17 15:26:46 +01:00
tibbi
455fa7eb77 do not clear media on destroy 2021-12-17 12:27:37 +01:00
tibbi
d51fa1385a avoid refreshing favorite items unnecessarily 2021-12-17 12:25:32 +01:00
Agnieszka C
adf2fc26da Fixed unknown date taken (#2295) 2021-12-08 15:30:38 +01:00
Agnieszka C
dc3ed3aa2f Added option to show file count in groups (#2281) 2021-12-06 18:49:09 +01:00
Tibor Kaputa
05fa21a085
Update MediaAdapter.kt 2021-12-05 23:30:02 +01:00
Tibor Kaputa
8c0f047809
Update DirectoryAdapter.kt 2021-12-05 23:29:28 +01:00
Tibor Kaputa
a83765705d
adding an empty line 2021-12-05 23:28:01 +01:00
Ebrahim Byagowi
dd8cd61450 Apply project's code style to api version checks 2021-12-06 01:32:45 +03:30
Ebrahim Byagowi
0e1a1cfb90 Check for api version at the target instead marking with RequiresApi 2021-12-06 01:28:39 +03:30
Ebrahim Byagowi
55499815c3 Remove now obsolete suppress lint annotations
They are no longer needed as the update in Simple-Common project.
2021-12-06 01:15:34 +03:30
tibbi
d4bf065cb5 adding a new MediaStoreId field to Medium model 2021-12-05 21:18:57 +01:00
tibbi
39b8ce7a08 updating the bottom action Toggle visibility tooltip to show current state 2021-12-05 18:35:19 +01:00
tibbi
8ae32e5490 reverting the icon visibility change 2021-12-05 18:31:37 +01:00
Tibor Kaputa
1950f776a3
Merge pull request #2286 from sidhantailawadi/fix_toggle_hide_unhide_icon
Reverses the condition to show the toggle hide/unhide icon (#2280)
2021-12-05 18:29:39 +01:00
tibbi
2634e09f7f avoid fetching the files multiple times at first launch 2021-12-05 16:54:19 +01:00
tibbi
79f30475c6 avoid calling file.list() or listFiles() on Android 11+ 2021-12-05 16:34:39 +01:00
tibbi
24efdebb86 avoid refetching mediastore items unnecessarily 2021-12-05 16:24:35 +01:00
tibbi
dae13c0261 improve the performance of fetching Android 11+ files, use the MediaStore 2021-12-04 22:24:50 +01:00
sidhantailawadi
98ed5c1991 Reverses the condition to show the toggle hide/unhide icon (#2280) 2021-12-04 16:40:33 +05:30
Tibor Kaputa
510f48c413
Merge pull request #2258 from Aga-C/mark-favorite-items
Added stars to mark favorite items (#2102)
2021-12-02 23:17:49 +01:00
tibbi
ea620a06c1 minor code formatting 2021-12-01 10:30:23 +01:00
Tibor Kaputa
aea7252b16
Merge pull request #2257 from Aga-C/add-rotate-permission
Fixed missing permission for rotate on external memory (#2236)
2021-12-01 10:29:31 +01:00
tibbi
05a81e53c5 simplifying a path check at deleting folders 2021-11-30 16:05:16 +01:00
Agnieszka C
1f47af7826 Moved handleRotate to the separate method 2021-11-30 15:55:10 +01:00