Hiding mark as favorite, smaller star icon, moved items on thumbnail

app/src/main/kotlin/com/simplemobiletools/gallery/pro/activities/MediaActivity.kt

@@ -73,6 +73,7 @@ class MediaActivity : SimpleActivity(), MediaOperationsListener {
     private var mStoredScrollHorizontally = true
     private var mStoredShowFileTypes = true
     private var mStoredRoundedCorners = false
+    private var mStoredMarkFavoriteItems = true
     private var mStoredTextColor = 0
     private var mStoredAdjustedPrimaryColor = 0
     private var mStoredThumbnailSpacing = 0
@@ -149,12 +150,11 @@ class MediaActivity : SimpleActivity(), MediaOperationsListener {
             getMediaAdapter()?.updatePrimaryColor(config.primaryColor)
         }
 
-        if (mStoredThumbnailSpacing != config.thumbnailSpacing) {
+        if (
-            media_grid.adapter = null
+            mStoredThumbnailSpacing != config.thumbnailSpacing
-            setupAdapter()
+            || mStoredRoundedCorners != config.fileRoundedCorners
-        }
+            || mStoredMarkFavoriteItems != config.markFavoriteItems
-
+        ) {
-        if (mStoredRoundedCorners != config.fileRoundedCorners) {
             media_grid.adapter = null
             setupAdapter()
         }
@@ -306,6 +306,7 @@ class MediaActivity : SimpleActivity(), MediaOperationsListener {
             mStoredCropThumbnails = cropThumbnails
             mStoredScrollHorizontally = scrollHorizontally
             mStoredShowFileTypes = showThumbnailFileTypes
+            mStoredMarkFavoriteItems = markFavoriteItems
             mStoredTextColor = textColor
             mStoredThumbnailSpacing = thumbnailSpacing
             mStoredRoundedCorners = fileRoundedCorners

app/src/main/kotlin/com/simplemobiletools/gallery/pro/activities/SettingsActivity.kt

@@ -731,6 +731,7 @@ class SettingsActivity : SimpleActivity() {
                 put(CROP_THUMBNAILS, config.cropThumbnails)
                 put(SHOW_THUMBNAIL_VIDEO_DURATION, config.showThumbnailVideoDuration)
                 put(SHOW_THUMBNAIL_FILE_TYPES, config.showThumbnailFileTypes)
+                put(MARK_FAVORITE_ITEMS, config.markFavoriteItems)
                 put(SCROLL_HORIZONTALLY, config.scrollHorizontally)
                 put(ENABLE_PULL_TO_REFRESH, config.enablePullToRefresh)
                 put(MAX_BRIGHTNESS, config.maxBrightness)
@@ -872,6 +873,7 @@ class SettingsActivity : SimpleActivity() {
                 CROP_THUMBNAILS -> config.cropThumbnails = value.toBoolean()
                 SHOW_THUMBNAIL_VIDEO_DURATION -> config.showThumbnailVideoDuration = value.toBoolean()
                 SHOW_THUMBNAIL_FILE_TYPES -> config.showThumbnailFileTypes = value.toBoolean()
+                MARK_FAVORITE_ITEMS -> config.markFavoriteItems = value.toBoolean()
                 SCROLL_HORIZONTALLY -> config.scrollHorizontally = value.toBoolean()
                 ENABLE_PULL_TO_REFRESH -> config.enablePullToRefresh = value.toBoolean()
                 MAX_BRIGHTNESS -> config.maxBrightness = value.toBoolean()

app/src/main/kotlin/com/simplemobiletools/gallery/pro/adapters/MediaAdapter.kt

@@ -525,7 +525,7 @@ class MediaAdapter(
 
             media_item_holder.setPadding(padding, padding, padding, padding)
 
-            favorite.beVisibleIf(medium.isFavorite)
+            favorite.beVisibleIf(medium.isFavorite && config.markFavoriteItems)
 
             play_portrait_outline?.beVisibleIf(medium.isVideo() || medium.isPortrait())
             if (medium.isVideo()) {

app/src/main/kotlin/com/simplemobiletools/gallery/pro/dialogs/ChangeFileThumbnailStyleDialog.kt

@@ -22,11 +22,13 @@ class ChangeFileThumbnailStyleDialog(val activity: BaseSimpleActivity) : DialogI
             dialog_file_style_animate_gifs.isChecked = config.animateGifs
             dialog_file_style_show_thumbnail_video_duration.isChecked = config.showThumbnailVideoDuration
             dialog_file_style_show_thumbnail_file_types.isChecked = config.showThumbnailFileTypes
+            dialog_file_style_mark_favorite_items.isChecked = config.markFavoriteItems
 
             dialog_file_style_rounded_corners_holder.setOnClickListener { dialog_file_style_rounded_corners.toggle() }
             dialog_file_style_animate_gifs_holder.setOnClickListener { dialog_file_style_animate_gifs.toggle() }
             dialog_file_style_show_thumbnail_video_duration_holder.setOnClickListener { dialog_file_style_show_thumbnail_video_duration.toggle() }
             dialog_file_style_show_thumbnail_file_types_holder.setOnClickListener { dialog_file_style_show_thumbnail_file_types.toggle() }
+            dialog_file_style_mark_favorite_items_holder.setOnClickListener { dialog_file_style_mark_favorite_items.toggle() }
 
             dialog_file_style_spacing_holder.setOnClickListener {
                 val items = arrayListOf(
@@ -61,6 +63,7 @@ class ChangeFileThumbnailStyleDialog(val activity: BaseSimpleActivity) : DialogI
         config.animateGifs = view.dialog_file_style_animate_gifs.isChecked
         config.showThumbnailVideoDuration = view.dialog_file_style_show_thumbnail_video_duration.isChecked
         config.showThumbnailFileTypes = view.dialog_file_style_show_thumbnail_file_types.isChecked
+        config.markFavoriteItems = view.dialog_file_style_mark_favorite_items.isChecked
         config.thumbnailSpacing = thumbnailSpacing
     }
 

app/src/main/kotlin/com/simplemobiletools/gallery/pro/helpers/Config.kt

@@ -167,6 +167,10 @@ class Config(context: Context) : BaseConfig(context) {
         get() = prefs.getBoolean(SHOW_THUMBNAIL_FILE_TYPES, true)
         set(showThumbnailFileTypes) = prefs.edit().putBoolean(SHOW_THUMBNAIL_FILE_TYPES, showThumbnailFileTypes).apply()
 
+    var markFavoriteItems: Boolean
+        get() = prefs.getBoolean(MARK_FAVORITE_ITEMS, true)
+        set(markFavoriteItems) = prefs.edit().putBoolean(MARK_FAVORITE_ITEMS, markFavoriteItems).apply()
+
     var screenRotation: Int
         get() = prefs.getInt(SCREEN_ROTATION, ROTATE_BY_SYSTEM_SETTING)
         set(screenRotation) = prefs.edit().putInt(SCREEN_ROTATION, screenRotation).apply()

app/src/main/kotlin/com/simplemobiletools/gallery/pro/helpers/Constants.kt

@@ -79,6 +79,7 @@ const val SHOW_NOTCH = "show_notch"
 const val FILE_LOADING_PRIORITY = "file_loading_priority"
 const val SPAM_FOLDERS_CHECKED = "spam_folders_checked"
 const val SHOW_THUMBNAIL_FILE_TYPES = "show_thumbnail_file_types"
+const val MARK_FAVORITE_ITEMS = "mark_favorite_items"
 const val EDITOR_BRUSH_COLOR = "editor_brush_color"
 const val EDITOR_BRUSH_HARDNESS = "editor_brush_hardness"
 const val EDITOR_BRUSH_SIZE = "editor_brush_size"

app/src/main/res/layout/dialog_change_file_thumbnail_style.xml

@@ -108,5 +108,21 @@
                 android:text="@string/show_image_file_types" />
 
         </RelativeLayout>
+
+        <RelativeLayout
+            android:id="@+id/dialog_file_style_mark_favorite_items_holder"
+            style="@style/SettingsHolderCheckboxStyle"
+            android:layout_width="match_parent"
+            android:layout_height="wrap_content"
+            android:background="?attr/selectableItemBackground">
+
+            <com.simplemobiletools.commons.views.MyAppCompatCheckbox
+                android:id="@+id/dialog_file_style_mark_favorite_items"
+                style="@style/SettingsCheckboxStyle"
+                android:layout_width="match_parent"
+                android:layout_height="wrap_content"
+                android:text="@string/mark_favorite_items" />
+
+        </RelativeLayout>
     </LinearLayout>
 </ScrollView>

app/src/main/res/layout/photo_item_grid.xml

@@ -17,7 +17,7 @@
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_alignParentStart="true"
-        android:layout_alignParentTop="true"
+        android:layout_alignParentBottom="true"
         android:layout_margin="@dimen/small_margin"
         android:fontFamily="sans-serif-medium"
         android:shadowColor="@color/default_background_color"
@@ -29,14 +29,15 @@
 
     <ImageView
         android:id="@+id/favorite"
-        android:layout_width="wrap_content"
+        android:layout_width="@dimen/favorite_icon_size"
-        android:layout_height="wrap_content"
+        android:layout_height="@dimen/favorite_icon_size"
         android:layout_alignParentTop="true"
-        android:layout_alignParentEnd="true"
+        android:layout_alignParentStart="true"
         android:layout_margin="@dimen/small_margin"
+        android:padding="@dimen/tiny_margin"
         android:gravity="end"
         android:background="@drawable/circle_black_background"
-        android:src="@drawable/ic_star_on_vector"
+        android:src="@drawable/ic_star_vector"
         android:visibility="gone" />
 
     <ImageView

app/src/main/res/layout/photo_item_list.xml

@@ -19,14 +19,15 @@
 
     <ImageView
         android:id="@+id/favorite"
-        android:layout_width="wrap_content"
+        android:layout_width="@dimen/favorite_icon_size"
-        android:layout_height="wrap_content"
+        android:layout_height="@dimen/favorite_icon_size"
         android:layout_alignParentTop="true"
         android:layout_alignParentEnd="true"
         android:layout_margin="@dimen/small_margin"
+        android:padding="@dimen/tiny_margin"
         android:gravity="end"
         android:background="@drawable/circle_black_background"
-        android:src="@drawable/ic_star_on_vector"
+        android:src="@drawable/ic_star_vector"
         android:visibility="gone" />
 
     <ImageView

app/src/main/res/layout/video_item_grid.xml

@@ -17,21 +17,22 @@
         android:layout_width="@dimen/selection_check_size"
         android:layout_height="@dimen/selection_check_size"
         android:layout_alignParentStart="true"
-        android:layout_alignParentTop="true"
+        android:layout_alignParentBottom="true"
         android:layout_margin="@dimen/small_margin"
         android:src="@drawable/ic_play_outline_vector"
         android:visibility="gone" />
 
     <ImageView
         android:id="@+id/favorite"
-        android:layout_width="wrap_content"
+        android:layout_width="@dimen/favorite_icon_size"
-        android:layout_height="wrap_content"
+        android:layout_height="@dimen/favorite_icon_size"
         android:layout_alignParentTop="true"
-        android:layout_alignParentEnd="true"
+        android:layout_alignParentStart="true"
         android:layout_margin="@dimen/small_margin"
+        android:padding="@dimen/tiny_margin"
         android:gravity="end"
         android:background="@drawable/circle_black_background"
-        android:src="@drawable/ic_star_on_vector"
+        android:src="@drawable/ic_star_vector"
         android:visibility="gone" />
 
     <TextView

app/src/main/res/layout/video_item_list.xml

@@ -19,14 +19,15 @@
 
     <ImageView
         android:id="@+id/favorite"
-        android:layout_width="wrap_content"
+        android:layout_width="@dimen/favorite_icon_size"
-        android:layout_height="wrap_content"
+        android:layout_height="@dimen/favorite_icon_size"
         android:layout_alignParentTop="true"
         android:layout_alignParentEnd="true"
         android:layout_margin="@dimen/small_margin"
+        android:padding="@dimen/tiny_margin"
         android:gravity="end"
         android:background="@drawable/circle_black_background"
-        android:src="@drawable/ic_star_on_vector"
+        android:src="@drawable/ic_star_vector"
         android:visibility="gone" />
 
     <ImageView

app/src/main/res/values/dimens.xml

@@ -4,6 +4,7 @@
     <dimen name="medium_tmb_size">100dp</dimen>
     <dimen name="sd_card_icon_size">20dp</dimen>
     <dimen name="play_outline_icon_size">22dp</dimen>
+    <dimen name="favorite_icon_size">24dp</dimen>
     <dimen name="selection_check_size">26dp</dimen>
     <dimen name="drag_handle_size">34dp</dimen>
     <dimen name="play_outline_size_big">96dp</dimen>