From 7d218d780eab5fedc4ad8834418952b9fb5999b9 Mon Sep 17 00:00:00 2001
From: gmasil <54176035+gmasil@users.noreply.github.com>
Date: Tue, 19 Dec 2023 07:57:46 +0100
Subject: [PATCH 1/4] increase visibility of video duration in thumbnails

---
 app/src/main/res/drawable/darkened_rounded_background.xml | 5 +++++
 app/src/main/res/layout/video_item_grid.xml               | 5 ++++-
 2 files changed, 9 insertions(+), 1 deletion(-)
 create mode 100644 app/src/main/res/drawable/darkened_rounded_background.xml

diff --git a/app/src/main/res/drawable/darkened_rounded_background.xml b/app/src/main/res/drawable/darkened_rounded_background.xml
new file mode 100644
index 000000000..fb279cd13
--- /dev/null
+++ b/app/src/main/res/drawable/darkened_rounded_background.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<shape xmlns:android="http://schemas.android.com/apk/res/android" android:shape="rectangle">
+    <corners android:radius="@dimen/rounded_corner_radius_small"/>
+    <solid android:color="@color/hint_black"/>
+</shape>
diff --git a/app/src/main/res/layout/video_item_grid.xml b/app/src/main/res/layout/video_item_grid.xml
index c9cff3354..0cf042aae 100644
--- a/app/src/main/res/layout/video_item_grid.xml
+++ b/app/src/main/res/layout/video_item_grid.xml
@@ -41,7 +41,7 @@
         android:layout_height="wrap_content"
         android:layout_alignTop="@+id/play_portrait_outline"
         android:layout_alignBottom="@+id/play_portrait_outline"
-        android:layout_marginTop="@dimen/small_margin"
+        android:layout_marginTop="@dimen/tiny_margin"
         android:layout_toEndOf="@id/play_portrait_outline"
         android:ellipsize="end"
         android:gravity="end"
@@ -51,6 +51,9 @@
         android:textColor="@android:color/white"
         android:textSize="@dimen/normal_text_size"
         android:visibility="gone"
+        android:background="@drawable/darkened_rounded_background"
+        android:paddingTop="@dimen/one_dp"
+        android:paddingHorizontal="@dimen/small_margin"
         tools:text="02:34" />
 
     <ImageView

From bfcf0185705a1840baa3c6bbb5c40392d53f4e1f Mon Sep 17 00:00:00 2001
From: gmasil <54176035+gmasil@users.noreply.github.com>
Date: Tue, 19 Dec 2023 15:29:19 +0100
Subject: [PATCH 2/4] combine play icon and duration of video thumbnails

---
 .../fossify/gallery/adapters/MediaAdapter.kt  |  2 +-
 ... darkened_automatic_circle_background.xml} |  2 +-
 app/src/main/res/drawable/ic_play_vector.xml  |  3 +
 app/src/main/res/layout/video_item_grid.xml   | 64 +++++++++++--------
 4 files changed, 41 insertions(+), 30 deletions(-)
 rename app/src/main/res/drawable/{darkened_rounded_background.xml => darkened_automatic_circle_background.xml} (73%)
 create mode 100644 app/src/main/res/drawable/ic_play_vector.xml

diff --git a/app/src/main/kotlin/org/fossify/gallery/adapters/MediaAdapter.kt b/app/src/main/kotlin/org/fossify/gallery/adapters/MediaAdapter.kt
index 07f7f91b8..c40b45e9a 100644
--- a/app/src/main/kotlin/org/fossify/gallery/adapters/MediaAdapter.kt
+++ b/app/src/main/kotlin/org/fossify/gallery/adapters/MediaAdapter.kt
@@ -619,7 +619,7 @@ class MediaAdapter(
 
             playPortraitOutline?.beVisibleIf(medium.isVideo() || medium.isPortrait())
             if (medium.isVideo()) {
-                playPortraitOutline?.setImageResource(org.fossify.commons.R.drawable.ic_play_outline_vector)
+                playPortraitOutline?.setImageResource(org.fossify.commons.R.drawable.ic_play_vector)
                 playPortraitOutline?.beVisible()
             } else if (medium.isPortrait()) {
                 playPortraitOutline?.setImageResource(R.drawable.ic_portrait_photo_vector)
diff --git a/app/src/main/res/drawable/darkened_rounded_background.xml b/app/src/main/res/drawable/darkened_automatic_circle_background.xml
similarity index 73%
rename from app/src/main/res/drawable/darkened_rounded_background.xml
rename to app/src/main/res/drawable/darkened_automatic_circle_background.xml
index fb279cd13..ea41f18df 100644
--- a/app/src/main/res/drawable/darkened_rounded_background.xml
+++ b/app/src/main/res/drawable/darkened_automatic_circle_background.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <shape xmlns:android="http://schemas.android.com/apk/res/android" android:shape="rectangle">
-    <corners android:radius="@dimen/rounded_corner_radius_small"/>
+    <corners android:radius="200000dp"/>
     <solid android:color="@color/hint_black"/>
 </shape>
diff --git a/app/src/main/res/drawable/ic_play_vector.xml b/app/src/main/res/drawable/ic_play_vector.xml
new file mode 100644
index 000000000..e30ede9eb
--- /dev/null
+++ b/app/src/main/res/drawable/ic_play_vector.xml
@@ -0,0 +1,3 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android" android:width="24dp" android:height="24dp" android:viewportWidth="24" android:viewportHeight="24">
+    <path android:fillColor="#FFFFFF" android:pathData="M16.247 11.424l-5.61-4.079c-0.206-0.149-0.48-0.171-0.705-0.055-0.228 0.115-0.37 0.348-0.37 0.601v8.154c0 0.255 0.142 0.488 0.37 0.603 0.096 0.049 0.201 0.073 0.307 0.073 0.139 0 0.279-0.044 0.398-0.131l5.61-4.075c0.177-0.13 0.28-0.332 0.28-0.546 0.001-0.217-0.105-0.418-0.28-0.545z"/>
+</vector>
diff --git a/app/src/main/res/layout/video_item_grid.xml b/app/src/main/res/layout/video_item_grid.xml
index 0cf042aae..c4aaea443 100644
--- a/app/src/main/res/layout/video_item_grid.xml
+++ b/app/src/main/res/layout/video_item_grid.xml
@@ -12,16 +12,6 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent" />
 
-    <ImageView
-        android:id="@+id/play_portrait_outline"
-        android:layout_width="@dimen/selection_check_size"
-        android:layout_height="@dimen/selection_check_size"
-        android:layout_alignParentStart="true"
-        android:layout_alignParentTop="true"
-        android:layout_margin="@dimen/small_margin"
-        android:src="@drawable/ic_play_outline_vector"
-        android:visibility="gone" />
-
     <ImageView
         android:id="@+id/favorite"
         android:layout_width="@dimen/selection_check_size"
@@ -35,26 +25,44 @@
         android:src="@drawable/ic_star_vector"
         android:visibility="gone" />
 
-    <TextView
-        android:id="@+id/video_duration"
+    <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+        xmlns:tools="http://schemas.android.com/tools"
+        android:id="@+id/play_icon_holder"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:layout_alignTop="@+id/play_portrait_outline"
-        android:layout_alignBottom="@+id/play_portrait_outline"
-        android:layout_marginTop="@dimen/tiny_margin"
-        android:layout_toEndOf="@id/play_portrait_outline"
-        android:ellipsize="end"
-        android:gravity="end"
-        android:maxLines="1"
-        android:shadowColor="@color/md_grey_black_dark"
-        android:shadowRadius="6"
-        android:textColor="@android:color/white"
-        android:textSize="@dimen/normal_text_size"
-        android:visibility="gone"
-        android:background="@drawable/darkened_rounded_background"
-        android:paddingTop="@dimen/one_dp"
-        android:paddingHorizontal="@dimen/small_margin"
-        tools:text="02:34" />
+        android:layout_marginTop="@dimen/small_margin"
+        android:layout_marginLeft="@dimen/small_margin"
+        android:background="@drawable/darkened_automatic_circle_background" >
+
+        <ImageView
+            android:id="@+id/play_portrait_outline"
+            android:layout_width="@dimen/selection_check_size"
+            android:layout_height="@dimen/selection_check_size"
+            android:layout_alignParentStart="true"
+            android:layout_alignParentTop="true"
+            android:layout_margin="0dp"
+            android:visibility="gone" />
+
+        <TextView
+            android:id="@+id/video_duration"
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:layout_alignTop="@+id/play_portrait_outline"
+            android:layout_alignBottom="@+id/play_portrait_outline"
+            android:layout_marginTop="@dimen/tiny_margin"
+            android:layout_marginRight="10dp"
+            android:layout_toEndOf="@id/play_portrait_outline"
+            android:ellipsize="end"
+            android:gravity="end"
+            android:maxLines="1"
+            android:shadowColor="@color/md_grey_black_dark"
+            android:shadowRadius="6"
+            android:textColor="@android:color/white"
+            android:textSize="@dimen/normal_text_size"
+            android:visibility="gone"
+            tools:text="02:34" />
+
+    </RelativeLayout>
 
     <ImageView
         android:id="@+id/medium_check"

From adbaaea6339dc23c2d116d10b8cabd2a689440e6 Mon Sep 17 00:00:00 2001
From: gmasil <54176035+gmasil@users.noreply.github.com>
Date: Tue, 19 Dec 2023 17:24:53 +0100
Subject: [PATCH 3/4] align play icon and video duration text

---
 app/src/main/res/layout/video_item_grid.xml | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/app/src/main/res/layout/video_item_grid.xml b/app/src/main/res/layout/video_item_grid.xml
index c4aaea443..1613377b5 100644
--- a/app/src/main/res/layout/video_item_grid.xml
+++ b/app/src/main/res/layout/video_item_grid.xml
@@ -29,7 +29,7 @@
         xmlns:tools="http://schemas.android.com/tools"
         android:id="@+id/play_icon_holder"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_height="@dimen/selection_check_size"
         android:layout_marginTop="@dimen/small_margin"
         android:layout_marginLeft="@dimen/small_margin"
         android:background="@drawable/darkened_automatic_circle_background" >
@@ -46,14 +46,12 @@
         <TextView
             android:id="@+id/video_duration"
             android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:layout_alignTop="@+id/play_portrait_outline"
-            android:layout_alignBottom="@+id/play_portrait_outline"
-            android:layout_marginTop="@dimen/tiny_margin"
+            android:layout_height="match_parent"
             android:layout_marginRight="10dp"
             android:layout_toEndOf="@id/play_portrait_outline"
+            android:paddingBottom="2dp"
             android:ellipsize="end"
-            android:gravity="end"
+            android:gravity="center"
             android:maxLines="1"
             android:shadowColor="@color/md_grey_black_dark"
             android:shadowRadius="6"

From a5195bb38fb3fce3b8c1a0bc76be750049cc9dfb Mon Sep 17 00:00:00 2001
From: gmasil <54176035+gmasil@users.noreply.github.com>
Date: Thu, 21 Dec 2023 17:46:04 +0100
Subject: [PATCH 4/4] fix review findings

---
 .../drawable/darkened_automatic_circle_background.xml  |  2 +-
 app/src/main/res/layout/video_item_grid.xml            | 10 ++++------
 2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/app/src/main/res/drawable/darkened_automatic_circle_background.xml b/app/src/main/res/drawable/darkened_automatic_circle_background.xml
index ea41f18df..a28fbcb29 100644
--- a/app/src/main/res/drawable/darkened_automatic_circle_background.xml
+++ b/app/src/main/res/drawable/darkened_automatic_circle_background.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <shape xmlns:android="http://schemas.android.com/apk/res/android" android:shape="rectangle">
-    <corners android:radius="200000dp"/>
+    <corners android:radius="@dimen/selection_check_size"/>
     <solid android:color="@color/hint_black"/>
 </shape>
diff --git a/app/src/main/res/layout/video_item_grid.xml b/app/src/main/res/layout/video_item_grid.xml
index 1613377b5..b2d31ea92 100644
--- a/app/src/main/res/layout/video_item_grid.xml
+++ b/app/src/main/res/layout/video_item_grid.xml
@@ -25,11 +25,12 @@
         android:src="@drawable/ic_star_vector"
         android:visibility="gone" />
 
-    <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
-        xmlns:tools="http://schemas.android.com/tools"
+    <RelativeLayout
         android:id="@+id/play_icon_holder"
         android:layout_width="wrap_content"
         android:layout_height="@dimen/selection_check_size"
+        android:layout_alignParentStart="true"
+        android:layout_alignParentTop="true"
         android:layout_marginTop="@dimen/small_margin"
         android:layout_marginLeft="@dimen/small_margin"
         android:background="@drawable/darkened_automatic_circle_background" >
@@ -47,14 +48,11 @@
             android:id="@+id/video_duration"
             android:layout_width="wrap_content"
             android:layout_height="match_parent"
-            android:layout_marginRight="10dp"
+            android:layout_marginEnd="10dp"
             android:layout_toEndOf="@id/play_portrait_outline"
-            android:paddingBottom="2dp"
             android:ellipsize="end"
             android:gravity="center"
             android:maxLines="1"
-            android:shadowColor="@color/md_grey_black_dark"
-            android:shadowRadius="6"
             android:textColor="@android:color/white"
             android:textSize="@dimen/normal_text_size"
             android:visibility="gone"