code review feedback

This commit is contained in:
Brian Floersch 2018-01-14 17:48:00 -05:00
parent 1942140187
commit 39e8541000
26 changed files with 26 additions and 2 deletions

View file

@ -170,7 +170,7 @@ class Config(context: Context) : BaseConfig(context) {
var oneFingerZoom: Boolean var oneFingerZoom: Boolean
get() = prefs.getBoolean(ONE_FINGER_ZOOM, false) get() = prefs.getBoolean(ONE_FINGER_ZOOM, false)
set(loop) = prefs.edit().putBoolean(ONE_FINGER_ZOOM, loop).apply() set(oneFingerZoom) = prefs.edit().putBoolean(ONE_FINGER_ZOOM, oneFingerZoom).apply()
private fun getDirectoryColumnsField(): String { private fun getDirectoryColumnsField(): String {
val isPortrait = context.resources.configuration.orientation == Configuration.ORIENTATION_PORTRAIT val isPortrait = context.resources.configuration.orientation == Configuration.ORIENTATION_PORTRAIT

View file

@ -135,6 +135,7 @@
<string name="replace_share_with_rotate">استبدال خيار المشاركة مع خيار تدوير في القائمة ملء الشاشة</string> <string name="replace_share_with_rotate">استبدال خيار المشاركة مع خيار تدوير في القائمة ملء الشاشة</string>
<string name="show_extended_details">عرض تفاصيل موسعة على وسائط ملء الشاشة</string> <string name="show_extended_details">عرض تفاصيل موسعة على وسائط ملء الشاشة</string>
<string name="manage_extended_details">إدارة المجلدات المستبعدة</string> <string name="manage_extended_details">إدارة المجلدات المستبعدة</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Reemplaçar Compartir per Girar al menú de pantalla complerta</string> <string name="replace_share_with_rotate">Reemplaçar Compartir per Girar al menú de pantalla complerta</string>
<string name="show_extended_details">Mostrar detalls estesos sobre mitjans a pantalla complerta</string> <string name="show_extended_details">Mostrar detalls estesos sobre mitjans a pantalla complerta</string>
<string name="manage_extended_details">Gestioneu els detalls ampliats</string> <string name="manage_extended_details">Gestioneu els detalls ampliats</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Replace Share with Rotate at fullscreen menu</string> <string name="replace_share_with_rotate">Replace Share with Rotate at fullscreen menu</string>
<string name="show_extended_details">Show extended details over fullscreen media</string> <string name="show_extended_details">Show extended details over fullscreen media</string>
<string name="manage_extended_details">Manage extended details</string> <string name="manage_extended_details">Manage extended details</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Teilen/Drehen im Vollbild-Menü vertauschen</string> <string name="replace_share_with_rotate">Teilen/Drehen im Vollbild-Menü vertauschen</string>
<string name="show_extended_details">Eigenschaften anzeigen im Vollbild</string> <string name="show_extended_details">Eigenschaften anzeigen im Vollbild</string>
<string name="manage_extended_details">Eigenschaften auswählen</string> <string name="manage_extended_details">Eigenschaften auswählen</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Reemplazar Compartir con Girar en el menú de pantalla completa</string> <string name="replace_share_with_rotate">Reemplazar Compartir con Girar en el menú de pantalla completa</string>
<string name="show_extended_details">Mostrar detalles extendidos sobre medios en pantalla completa</string> <string name="show_extended_details">Mostrar detalles extendidos sobre medios en pantalla completa</string>
<string name="manage_extended_details">Administrar detalles ampliados</string> <string name="manage_extended_details">Administrar detalles ampliados</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Korvaa jakaminen kääntämisellä koko näytön tilassa</string> <string name="replace_share_with_rotate">Korvaa jakaminen kääntämisellä koko näytön tilassa</string>
<string name="show_extended_details">Show extended details over fullscreen media</string> <string name="show_extended_details">Show extended details over fullscreen media</string>
<string name="manage_extended_details">Manage extended details</string> <string name="manage_extended_details">Manage extended details</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Remplacer Partager par Pivoter si menu en plein écran</string> <string name="replace_share_with_rotate">Remplacer Partager par Pivoter si menu en plein écran</string>
<string name="show_extended_details">Afficher les détails supplémentaires par dessus le média en plein écran</string> <string name="show_extended_details">Afficher les détails supplémentaires par dessus le média en plein écran</string>
<string name="manage_extended_details">Gérer les détails supplémentaires</string> <string name="manage_extended_details">Gérer les détails supplémentaires</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Substituír Compartir con Rotar no menú de pantalla completa</string> <string name="replace_share_with_rotate">Substituír Compartir con Rotar no menú de pantalla completa</string>
<string name="show_extended_details">Mostrar información pormenorizada sobre medios a pantalla completa</string> <string name="show_extended_details">Mostrar información pormenorizada sobre medios a pantalla completa</string>
<string name="manage_extended_details">Xestionar información polo miúdo</string> <string name="manage_extended_details">Xestionar información polo miúdo</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Zamjeni Dijeli s Rotiraj pri pregledu datoteka</string> <string name="replace_share_with_rotate">Zamjeni Dijeli s Rotiraj pri pregledu datoteka</string>
<string name="show_extended_details">Prikaži detaljne informacije pri pregledu datoteka</string> <string name="show_extended_details">Prikaži detaljne informacije pri pregledu datoteka</string>
<string name="manage_extended_details">Upravljaj detaljnim informacijama</string> <string name="manage_extended_details">Upravljaj detaljnim informacijama</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Replace Share with Rotate at fullscreen menu</string> <string name="replace_share_with_rotate">Replace Share with Rotate at fullscreen menu</string>
<string name="show_extended_details">Show extended details over fullscreen media</string> <string name="show_extended_details">Show extended details over fullscreen media</string>
<string name="manage_extended_details">Manage extended details</string> <string name="manage_extended_details">Manage extended details</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Sostituisci Condividi con Ruota a schermo intero</string> <string name="replace_share_with_rotate">Sostituisci Condividi con Ruota a schermo intero</string>
<string name="show_extended_details">Mostra informazioni estese su media a schermo intero</string> <string name="show_extended_details">Mostra informazioni estese su media a schermo intero</string>
<string name="manage_extended_details">Gestisci le informazioni estese</string> <string name="manage_extended_details">Gestisci le informazioni estese</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">フルスクリーンメニューの「共有」を「回転」に置き換える</string> <string name="replace_share_with_rotate">フルスクリーンメニューの「共有」を「回転」に置き換える</string>
<string name="show_extended_details">Show extended details over fullscreen media</string> <string name="show_extended_details">Show extended details over fullscreen media</string>
<string name="manage_extended_details">Manage extended details</string> <string name="manage_extended_details">Manage extended details</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">전체화면 메뉴의 공유 아이콘을 회전 아이콘으로 변경</string> <string name="replace_share_with_rotate">전체화면 메뉴의 공유 아이콘을 회전 아이콘으로 변경</string>
<string name="show_extended_details">전체화면 모드에서 세부정보 표시</string> <string name="show_extended_details">전체화면 모드에서 세부정보 표시</string>
<string name="manage_extended_details">확장된 세부정보 관리</string> <string name="manage_extended_details">확장된 세부정보 관리</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Erstatt Del med Roter i meny ved mediavisning</string> <string name="replace_share_with_rotate">Erstatt Del med Roter i meny ved mediavisning</string>
<string name="show_extended_details">Vis flere detaljer i mediavisningen</string> <string name="show_extended_details">Vis flere detaljer i mediavisningen</string>
<string name="manage_extended_details">Velg detaljer</string> <string name="manage_extended_details">Velg detaljer</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Menu-item Draaien vastzetten in volledige weergave (in plaats van Delen)</string> <string name="replace_share_with_rotate">Menu-item Draaien vastzetten in volledige weergave (in plaats van Delen)</string>
<string name="show_extended_details">Uitgebreide informatie tonen in volledige weergave</string> <string name="show_extended_details">Uitgebreide informatie tonen in volledige weergave</string>
<string name="manage_extended_details">Uitgebreide informatie</string> <string name="manage_extended_details">Uitgebreide informatie</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Zamień funkcję udostępniania na obracanie w menu pełnoekranowym</string> <string name="replace_share_with_rotate">Zamień funkcję udostępniania na obracanie w menu pełnoekranowym</string>
<string name="show_extended_details">Dodatkowe szczegóły przy podglądzie pełnoekranowym</string> <string name="show_extended_details">Dodatkowe szczegóły przy podglądzie pełnoekranowym</string>
<string name="manage_extended_details">Zarządzaj dodatkowymi szczegółami</string> <string name="manage_extended_details">Zarządzaj dodatkowymi szczegółami</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Substituir botão "Compartilhar" por "Rotação de tela" quando em tela cheia</string> <string name="replace_share_with_rotate">Substituir botão "Compartilhar" por "Rotação de tela" quando em tela cheia</string>
<string name="show_extended_details">Exibir detalhes extendidos quando em tela cheia</string> <string name="show_extended_details">Exibir detalhes extendidos quando em tela cheia</string>
<string name="manage_extended_details">Gerenciar detalhes extendidos</string> <string name="manage_extended_details">Gerenciar detalhes extendidos</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Substituir a opção Partilhar pela opção Rodar se em ecrã completo</string> <string name="replace_share_with_rotate">Substituir a opção Partilhar pela opção Rodar se em ecrã completo</string>
<string name="show_extended_details">Mostrar detalhes se em ecrã completo</string> <string name="show_extended_details">Mostrar detalhes se em ecrã completo</string>
<string name="manage_extended_details">Gerir detalhes exibidos</string> <string name="manage_extended_details">Gerir detalhes exibidos</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Заменить \"Поделиться\" на \"Повернуть\" в меню полноэкранного режима</string> <string name="replace_share_with_rotate">Заменить \"Поделиться\" на \"Повернуть\" в меню полноэкранного режима</string>
<string name="show_extended_details">Показывать детали файла</string> <string name="show_extended_details">Показывать детали файла</string>
<string name="manage_extended_details">Выбрать детали файла</string> <string name="manage_extended_details">Выбрать детали файла</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Nahradiť Zdieľanie s Otočením v celoobrazovkovom menu</string> <string name="replace_share_with_rotate">Nahradiť Zdieľanie s Otočením v celoobrazovkovom menu</string>
<string name="show_extended_details">Zobraziť rozšírené vlastnosti ponad celoobrazovkové médiá</string> <string name="show_extended_details">Zobraziť rozšírené vlastnosti ponad celoobrazovkové médiá</string>
<string name="manage_extended_details">Spravovať rozšírené vlastnosti</string> <string name="manage_extended_details">Spravovať rozšírené vlastnosti</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Ersätt Dela med Rotera i helskärmsmenyn</string> <string name="replace_share_with_rotate">Ersätt Dela med Rotera i helskärmsmenyn</string>
<string name="show_extended_details">Visa utökad information över media i helskärmsläge</string> <string name="show_extended_details">Visa utökad information över media i helskärmsläge</string>
<string name="manage_extended_details">Hantera utökad information</string> <string name="manage_extended_details">Hantera utökad information</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Replace Share with Rotate at fullscreen menu</string> <string name="replace_share_with_rotate">Replace Share with Rotate at fullscreen menu</string>
<string name="show_extended_details">Show extended details over fullscreen media</string> <string name="show_extended_details">Show extended details over fullscreen media</string>
<string name="manage_extended_details">Manage extended details</string> <string name="manage_extended_details">Manage extended details</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">替换全屏时菜单栏的“分享”为“旋转”</string> <string name="replace_share_with_rotate">替换全屏时菜单栏的“分享”为“旋转”</string>
<string name="show_extended_details">全屏浏览媒体时显示详细信息</string> <string name="show_extended_details">全屏浏览媒体时显示详细信息</string>
<string name="manage_extended_details">要显示的详细信息项目</string> <string name="manage_extended_details">要显示的详细信息项目</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">將全螢幕選單的分享取代為旋轉</string> <string name="replace_share_with_rotate">將全螢幕選單的分享取代為旋轉</string>
<string name="show_extended_details">全螢幕時顯示詳細資訊</string> <string name="show_extended_details">全螢幕時顯示詳細資訊</string>
<string name="manage_extended_details">管理詳細資訊</string> <string name="manage_extended_details">管理詳細資訊</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->

View file

@ -131,6 +131,7 @@
<string name="replace_share_with_rotate">Replace Share with Rotate at fullscreen menu</string> <string name="replace_share_with_rotate">Replace Share with Rotate at fullscreen menu</string>
<string name="show_extended_details">Show extended details over fullscreen media</string> <string name="show_extended_details">Show extended details over fullscreen media</string>
<string name="manage_extended_details">Manage extended details</string> <string name="manage_extended_details">Manage extended details</string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- Strings displayed only on Google Playstore. Optional, but good to have --> <!-- Strings displayed only on Google Playstore. Optional, but good to have -->
<!-- Short description has to have less than 80 chars --> <!-- Short description has to have less than 80 chars -->
@ -146,7 +147,6 @@
This app is just one piece of a bigger series of apps. You can find the rest of them at http://www.simplemobiletools.com This app is just one piece of a bigger series of apps. You can find the rest of them at http://www.simplemobiletools.com
</string> </string>
<string name="one_finger_zoom">Toggle one finger zoom</string>
<!-- <!--
Haven't found some strings? There's more at Haven't found some strings? There's more at