Update Features, add todos, remove wrong comments

Maybe next Time I should reread the spec, instead
of relying on memory from half a year ago
This commit is contained in:
Felisp 2024-11-08 00:19:31 +01:00
parent a28817a93d
commit 98b8e2b3bf
3 changed files with 3 additions and 5 deletions

View file

@ -1,7 +1,7 @@
* Features non exhaustive list of TODOs * Features non exhaustive list of TODOs
Some todos collected from source code, sorted roughly in the order of importance Some todos collected from source code, sorted roughly in the order of importance
- [-] *Most important features* [0%] - [-] *Most important features* [9%]
- [-] Navigation stack with loaded items and urls [1/3] - [-] Navigation stack with loaded items and urls [1/3]
- [X] Capture the back key - [X] Capture the back key
- [ ] Add buttons to go back & forth - [ ] Add buttons to go back & forth
@ -10,7 +10,7 @@ Some todos collected from source code, sorted roughly in the order of importance
- [ ] Add toolbar with disable wrap button - [ ] Add toolbar with disable wrap button
- [ ] Menu should be nonwrapping by default - [ ] Menu should be nonwrapping by default
- [ ] Add option to wrap only filenames and not info items as they may be just decoration - [ ] Add option to wrap only filenames and not info items as they may be just decoration
- [ ] [[https://github.com/llfbandit/app_links/blob/master/doc/README_android.md][Register to handle]] ~gopher://~ protocol - [X] [[https://github.com/llfbandit/app_links/blob/master/doc/README_android.md][Register to handle]] ~gopher://~ protocol
- [ ] Keep toolbar url up to date - [ ] Keep toolbar url up to date
- [ ] Fix line reading from socket - [ ] Fix line reading from socket
- [ ] Bookmarks - [ ] Bookmarks

View file

@ -169,8 +169,6 @@ class ParsedGopherItem {
for (int i = 0; i < rcvd.length; i++) { for (int i = 0; i < rcvd.length; i++) {
if (rcvd[i] == "\n") { if (rcvd[i] == "\n") {
var menuLine = rcvd.substring(start, i); var menuLine = rcvd.substring(start, i);
// TODO: Gophernicus sends .\r for some reason which doesnt seem acording to spec
// Maybe ignore when sent from menu=forced?
if (menuLine.startsWith(".")) { if (menuLine.startsWith(".")) {
print("Received starting dot, this should be the end I guess"); print("Received starting dot, this should be the end I guess");
return; return;

View file

@ -67,7 +67,7 @@ class _GopherShyState extends State<GopherShy> {
), ),
), ),
// In future replace with bookmark view // In future replace with bookmark view
body: GopherBrowser( body: GopherBrowser( //TODO: replace default url with homepage from prefs
initialUrl: widget.fromIntentLink ?? "gopher://treebrary.org"), initialUrl: widget.fromIntentLink ?? "gopher://treebrary.org"),
)), )),
); );